Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite AzureBlobContainerRetriesTests#testRetryUntilFails #66531

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Rewrite AzureBlobContainerRetriesTests#testRetryUntilFails #66531

merged 1 commit into from
Dec 17, 2020

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Dec 17, 2020

This test was failing on 7.x and 7.11 branches and it was rewritten while
backporting. This commit adds the same approach to the latest version.

@fcofdez
Fix AzureBlobContainerRetriesTests#testRetryUntilFails
a552e79 
Add a clearer approach to this test
@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Dec 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

original-brownbear
original-brownbear approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@fcofdez fcofdez merged commit c96b3ba into elastic:master Dec 17, 2020
@mayya-sharipova mayya-sharipova mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@original-brownbear original-brownbear original-brownbear approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fcofdez @elasticmachine @original-brownbear @jakelandis