Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureBlobContainerRetriesTests testRetryUntilFail fails #66865

Closed
mayya-sharipova opened this issue Dec 29, 2020 · 2 comments · Fixed by #67077 or #67258
Closed

AzureBlobContainerRetriesTests testRetryUntilFail fails #66865

mayya-sharipova opened this issue Dec 29, 2020 · 2 comments · Fixed by #67077 or #67258
Assignees
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI

Comments

@mayya-sharipova
Copy link
Contributor

Build scan:
https://gradle-enterprise.elastic.co/s/yb7lph3epqlqy

Repro line:
./gradlew ':plugins:repository-azure:test' --tests "org.elasticsearch.repositories.azure.AzureBlobContainerRetriesTests.testRetryUntilFail"
-Dtests.seed=E146AF3527EDBEB
-Dtests.security.manager=true
-Dbuild.snapshot=false
-Dtests.jvm.argline="-Dbuild.snapshot=false"
-Dtests.locale=en-IE
-Dtests.timezone=America/Fort_Wayne
-Druntime.java=8

Reproduces locally?:
No

Applicable branches:
7.11, 7.x, master

Failure history:
9 failures from Dec 22 to Dec 29

Failure excerpt:

org.elasticsearch.repositories.azure.AzureBlobContainerRetriesTests > testRetryUntilFail FAILED
09:10:38     java.lang.AssertionError: 
09:10:38     Expected: <3>
09:10:38          but: was <2>
09:10:38         at __randomizedtesting.SeedInfo.seed([E146AF3527EDBEB:E214676353BDDD3B]:0)
09:10:38         at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
09:10:38         at org.junit.Assert.assertThat(Assert.java:956)
09:10:38         at org.junit.Assert.assertThat(Assert.java:923)
09:10:38         at org.elasticsearch.repositories.azure.AzureBlobContainerRetriesTests.testRetryUntilFail(AzureBlobContainerRetriesTests.java:440)

Possibly related to #66531

@mayya-sharipova mayya-sharipova added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels Dec 29, 2020
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Dec 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@fcofdez fcofdez self-assigned this Jan 5, 2021
fcofdez added a commit to fcofdez/elasticsearch that referenced this issue Jan 6, 2021
We were too agressive with retries and in certain scenarios (CI) it
was possible that when the SDK had retried n times the http handler
had some pending backlog that didn't account for all the performed
requests.

Closes elastic#66865
fcofdez added a commit that referenced this issue Jan 6, 2021
We were too agressive with retries and in certain scenarios (CI) it
was possible that when the SDK had retried n times the http handler
had some pending backlog that didn't account for all the performed
requests.

Closes #66865
fcofdez added a commit to fcofdez/elasticsearch that referenced this issue Jan 6, 2021
We were too agressive with retries and in certain scenarios (CI) it
was possible that when the SDK had retried n times the http handler
had some pending backlog that didn't account for all the performed
requests.

Closes elastic#66865
Backport of elastic#67077
fcofdez added a commit to fcofdez/elasticsearch that referenced this issue Jan 6, 2021
We were too agressive with retries and in certain scenarios (CI) it
was possible that when the SDK had retried n times the http handler
had some pending backlog that didn't account for all the performed
requests.

Closes elastic#66865
Backport of elastic#67077
fcofdez added a commit that referenced this issue Jan 6, 2021
We were too aggressive with retries and in certain scenarios (CI) it
was possible that when the SDK had retried n times the http handler
had some pending backlog that didn't account for all the performed
requests.

Closes #66865
Backport of #67077
fcofdez added a commit that referenced this issue Jan 6, 2021
We were too aggressive with retries and in certain scenarios (CI) it
was possible that when the SDK had retried n times the http handler
had some pending backlog that didn't account for all the performed
requests.

Closes #66865
Backport of #67077
@dimitris-athanasiou
Copy link
Contributor

While the original issue was fixed, it seems this test may still fail: https://gradle-enterprise.elastic.co/s/3vbyqe7zniqii

Failure:


com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler uncaughtException |  
-- | --
  | WARNING: Uncaught exception in thread: Thread[Thread-18,5,TGRP-AzureBlobContainerRetriesTests] |  
  | java.lang.AssertionError: |  
  | Expected: "connection closed before all data received" |  
  | but: was "Stream closed" |  
  | at __randomizedtesting.SeedInfo.seed([C84F4316D3721809]:0) |  
  | at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18) |  
  | at org.junit.Assert.assertThat(Assert.java:956) |  
  | at org.junit.Assert.assertThat(Assert.java:923) |  
  | at org.elasticsearch.repositories.azure.AzureBlobContainerRetriesTests.lambda$testRetryUntilFail$7(AzureBlobContainerRetriesTests.java:415) |  
  | at com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:79) |  
  | at sun.net.httpserver.AuthFilter.doFilter(AuthFilter.java:83) |  
  | at com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:82) |  
  | at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle(ServerImpl.java:675) |  
  | at com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:79) |  
  | at sun.net.httpserver.ServerImpl$Exchange.run(ServerImpl.java:647) |  
  | at sun.net.httpserver.ServerImpl$DefaultExecutor.execute(ServerImpl.java:158) |  
  | at sun.net.httpserver.ServerImpl$Dispatcher.handle(ServerImpl.java:431) |  
  | at sun.net.httpserver.ServerImpl$Dispatcher.run(ServerImpl.java:396) |  
  | at java.lang.Thread.run(Thread.java:748)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI
Projects
None yet
4 participants