Allow bootstrap plugins to appear in _cat/plugins #66260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap plugins are not loaded in the main Elasticsearch process, but instead take effect only when ES is starting. As such, these plugins are skipped when ES loads all installed plugins. As a result, it was impossible for the plugins _cat API to report whether any bootstrap plugins are installed. Fix this by adjusting how the loading process skips bootstrap plugins, and then tweaking the plugins _cat API so that bootstrap plugins can optionally be included in the response.
pugnascotia
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Dec 15, 2020
| @@ -106,12 +113,16 @@ private Table buildTable(RestRequest req, ClusterStateResponse state, NodesInfoR | |||
| continue; | |||
| } | |||
| for (PluginInfo pluginInfo : plugins.getPluginInfos()) { | |||
| if (pluginInfo.getType() == PluginType.BOOTSTRAP && includeBootstrapPlugins == false) { | |||
There was a problem hiding this comment.
We don't seem to have any unit tests for this class. Would it be possible to add a simple one? The packaging tests added seem to be testing this new flag, but that doesn't seem like the right place, since the flag doesn't directly have anything to do with the quota aware fs plugin, it's just the only example we have so far a bootstrap plugin.
There was a problem hiding this comment.
@rjernst I've added unit tests, please take a look.
pugnascotia
added a commit
that referenced
this pull request
Dec 17, 2020
Closes #66107. Bootstrap plugins are not loaded in the main Elasticsearch process, but instead take effect only when ES is starting. As such, these plugins are skipped when ES loads all installed plugins. As a result, it was impossible for the plugins _cat API to report whether any bootstrap plugins are installed. Fix this by adjusting how the loading process skips bootstrap plugins, and then tweaking the plugins _cat API so that bootstrap plugins can optionally be included in the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66107.
Bootstrap plugins are not loaded in the main Elasticsearch process, but
instead take effect only when ES is starting. As such, these plugins are
skipped when ES loads all installed plugins.
As a result, it was impossible for the plugins _cat API to report
whether any bootstrap plugins are installed.
Fix this by adjusting how the loading process skips bootstrap plugins,
and then tweaking the plugins _cat API so that bootstrap plugins can
optionally be included in the response.