Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_cat/plugins does not list quota-aware-fs plugin #66107

Closed
mieciu opened this issue Dec 9, 2020 · 2 comments · Fixed by #66260
Closed

_cat/plugins does not list quota-aware-fs plugin #66107

mieciu opened this issue Dec 9, 2020 · 2 comments · Fixed by #66260
Assignees
@pugnascotia
Labels
>bug :Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team

Comments

@mieciu
Copy link
Contributor

mieciu commented Dec 9, 2020

Elasticsearch version: 8.0.0-SNAPSHOT, 7.11.0-SNAPSHOT (possibly 6.8.14-SNAPSHOT as well)

Description of the problem including expected versus actual behavior:

The _cat/plugins API endpoint does not list quota-aware-fs plugin. The plugin gets installed successfully and is visible via /bin/elasticsearch-plugin tool:

bash-4.4# ./bin/elasticsearch-plugin list
quota-aware-fs
repository-s3

but the _cat/plugins endpoint response looks like this:

_cat/plugins?v
name                  component     version
instance-0000000000   repository-s3 8.0.0-SNAPSHOT
instance-0000000001   repository-s3 8.0.0-SNAPSHOT
tiebreaker-0000000002 repository-s3 8.0.0-SNAPSHOT

Steps to reproduce:

  1. Install quota-aware-fs plugin
  2. Shoot GET _cat/plugins?v

Related PRs: #63620 #64850
@mieciu mieciu added >bug needs:triage Requires assignment of a team area label labels Dec 9, 2020
@pugnascotia pugnascotia self-assigned this Dec 9, 2020
@jasontedor jasontedor added the :Core/Infra/Plugins Plugin API and infrastructure label Dec 9, 2020
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Dec 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst removed the needs:triage Requires assignment of a team area label label Dec 9, 2020
@pugnascotia
Copy link
Contributor

Right now, this is intentional behaviour. quota-aware-fs is a bootstrap plugin, meaning that it is specifically not loaded into Elasticsearch when it runs. However, we could tweak the loading so that the existence of the plugin can still be known, while still skipping the loading of its libraries.

@pugnascotia pugnascotia mentioned this issue Dec 14, 2020
Merged
pugnascotia added a commit that referenced this issue Dec 17, 2020
@pugnascotia
Allow bootstrap plugins to appear in _cat/plugins (#66260)
4ff6125 
Closes #66107.

Bootstrap plugins are not loaded in the main Elasticsearch process, but
instead take effect only when ES is starting. As such, these plugins are
skipped when ES loads all installed plugins.

As a result, it was impossible for the plugins _cat API to report
whether any bootstrap plugins are installed.

Fix this by adjusting how the loading process skips bootstrap plugins,
and then tweaking the plugins _cat API so that bootstrap plugins can
optionally be included in the response.
pugnascotia added a commit that referenced this issue Dec 17, 2020
@pugnascotia
Allow bootstrap plugins to appear in _cat/plugins (#66260)
d948960 
Closes #66107.

Bootstrap plugins are not loaded in the main Elasticsearch process, but
instead take effect only when ES is starting. As such, these plugins are
skipped when ES loads all installed plugins.

As a result, it was impossible for the plugins _cat API to report
whether any bootstrap plugins are installed.

Fix this by adjusting how the loading process skips bootstrap plugins,
and then tweaking the plugins _cat API so that bootstrap plugins can
optionally be included in the response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pugnascotia pugnascotia

Labels
>bug :Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow bootstrap plugins to appear in _cat/plugins pugnascotia/elasticsearch
5 participants
@rjernst @mieciu @jasontedor @pugnascotia @elasticmachine