Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add dynamic runtime fields to docs #66194

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Dec 10, 2020

Adds descriptions and usage of dynamic runtime fields introduced in #65489:

  • Introduces the runtime value for the dynamic parameter
  • Updates the Dynamic mapping page to discuss runtime fields
  • Updates the mapping section of the Runtime fields page to explain dynamic mapping
  • Includes related links between these pages

@lockewritesdocs lockewritesdocs added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 labels Dec 10, 2020
@lockewritesdocs lockewritesdocs self-assigned this Dec 10, 2020
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Docs Meta label for docs team labels Dec 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its already a great improvement! I've left a couple of question about ways maybe it could be even better? I really do wonder if it'd be better in the table on https://elasticsearch_66194.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/dynamic-field-mapping.html was three colunms wide.

docs/reference/mapping/dynamic/field-mapping.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/field-mapping.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/params/dynamic.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lockewritesdocs lockewritesdocs merged commit fe54c2f into elastic:master Dec 14, 2020
@lockewritesdocs lockewritesdocs deleted the docs__dynamic-runtime-fields branch December 14, 2020 21:37
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 14, 2020
* elastic/master: (33 commits)
  Add searchable snapshot cache folder to NodeEnvironment (elastic#66297)
  [DOCS] Add dynamic runtime fields to docs (elastic#66194)
  Add HDFS searchable snapshot integration (elastic#66185)
  Support canceling cross-clusters search requests (elastic#66206)
  Mute testCacheSurviveRestart (elastic#66289)
  Fix cat tasks api params in spec and handler (elastic#66272)
  Snapshot of a searchable snapshot should be empty (elastic#66162)
  [ML] DFA _explain API should not fail when none field is included (elastic#66281)
  Add action to decommission legacy monitoring cluster alerts (elastic#64373)
  move rollup_index param out of RollupActionConfig (elastic#66139)
  Improve FieldFetcher retrieval of fields (elastic#66160)
  Remove unsed fields in `RestAnalyzeAction` (elastic#66215)
  Simplify searchable snapshot CacheKey (elastic#66263)
  Autoscaling remove feature flags (elastic#65973)
  Improve searchable snapshot mount time (elastic#66198)
  [ML] Report cause when datafeed extraction encounters error (elastic#66167)
  Remove suggest reference in some API specs (elastic#66180)
  Fix warning when installing a plugin for different ESversion (elastic#66146)
  [ML] make `xpack.ml.max_ml_node_size` and `xpack.ml.use_auto_machine_memory_percent` dynamically settable (elastic#66132)
  [DOCS] Add `require_alias` to Bulk API (elastic#66259)
  ...
lockewritesdocs pushed a commit that referenced this pull request Dec 14, 2020
* [DOCS] Add dynamic runtime fields to docs.

* Clarifying edits and example changes.

* Creating better table and incorporating review comments.

* Change numeral to superscript.
@javanna
Copy link
Member

javanna commented Dec 16, 2020

thanks @lockewritesdocs I left a couple of minor comments that can be addressed as a follow-up if you think they make sense. Also, do you plan on expanding the dynamic template page as a follow-up to document the ability to map fields as runtime from a dynamic template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants