Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when installing a plugin for different ESversion #66146

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

flyingpot
Copy link
Contributor

@flyingpot flyingpot commented Dec 10, 2020

This commit change the warn message returned by elasticsearch-plugin list. The elasticsearch version of plugin is needed for comparison with current es version rather than the plugin version.

@flyingpot flyingpot changed the title Fix the warn of list plugin command when versions don't match Fix the warn message of list plugin command when versions don't match Dec 10, 2020
@tvernum tvernum added the :Core/Infra/Plugins Plugin API and infrastructure label Dec 14, 2020
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@tvernum
Copy link
Contributor

tvernum commented Dec 14, 2020

@elasticmachine test this please

@flyingpot flyingpot force-pushed the bug__fix-list-plugin-command branch from 30c5557 to 1268542 Compare December 14, 2020 15:26
@flyingpot
Copy link
Contributor Author

@tvernum I rebase the master and hope to solve the test failure.

@pugnascotia
Copy link
Contributor

@elasticmachine test this please

@pugnascotia pugnascotia changed the title Fix the warn message of list plugin command when versions don't match Fix the warning when trying to install a plugin for a different Elasticsearch version Dec 14, 2020
@pugnascotia pugnascotia changed the title Fix the warning when trying to install a plugin for a different Elasticsearch version Fix warning when installing a plugin for different ESversion Dec 14, 2020
@pugnascotia pugnascotia merged commit 2bf5c79 into elastic:master Dec 14, 2020
@pugnascotia
Copy link
Contributor

Thanks for the fix @flyingpot!

pugnascotia pushed a commit that referenced this pull request Dec 14, 2020
This commit change the warn message returned by elasticsearch-plugin list. The elasticsearch version of plugin is needed for comparison with current es version rather than the plugin version.
@pugnascotia
Copy link
Contributor

Backported to 7.x in f6933b4

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 14, 2020
* elastic/master: (33 commits)
  Add searchable snapshot cache folder to NodeEnvironment (elastic#66297)
  [DOCS] Add dynamic runtime fields to docs (elastic#66194)
  Add HDFS searchable snapshot integration (elastic#66185)
  Support canceling cross-clusters search requests (elastic#66206)
  Mute testCacheSurviveRestart (elastic#66289)
  Fix cat tasks api params in spec and handler (elastic#66272)
  Snapshot of a searchable snapshot should be empty (elastic#66162)
  [ML] DFA _explain API should not fail when none field is included (elastic#66281)
  Add action to decommission legacy monitoring cluster alerts (elastic#64373)
  move rollup_index param out of RollupActionConfig (elastic#66139)
  Improve FieldFetcher retrieval of fields (elastic#66160)
  Remove unsed fields in `RestAnalyzeAction` (elastic#66215)
  Simplify searchable snapshot CacheKey (elastic#66263)
  Autoscaling remove feature flags (elastic#65973)
  Improve searchable snapshot mount time (elastic#66198)
  [ML] Report cause when datafeed extraction encounters error (elastic#66167)
  Remove suggest reference in some API specs (elastic#66180)
  Fix warning when installing a plugin for different ESversion (elastic#66146)
  [ML] make `xpack.ml.max_ml_node_size` and `xpack.ml.use_auto_machine_memory_percent` dynamically settable (elastic#66132)
  [DOCS] Add `require_alias` to Bulk API (elastic#66259)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants