-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning when installing a plugin for different ESversion #66146
Merged
pugnascotia
merged 2 commits into
elastic:master
from
flyingpot:bug__fix-list-plugin-command
Dec 14, 2020
Merged
Fix warning when installing a plugin for different ESversion #66146
pugnascotia
merged 2 commits into
elastic:master
from
flyingpot:bug__fix-list-plugin-command
Dec 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingpot
changed the title
Fix the warn of list plugin command when versions don't match
Fix the warn message of list plugin command when versions don't match
Dec 10, 2020
Pinging @elastic/es-core-infra (Team:Core/Infra) |
@elasticmachine test this please |
flyingpot
force-pushed
the
bug__fix-list-plugin-command
branch
from
December 14, 2020 15:26
30c5557
to
1268542
Compare
@tvernum I rebase the master and hope to solve the test failure. |
@elasticmachine test this please |
pugnascotia
changed the title
Fix the warn message of list plugin command when versions don't match
Fix the warning when trying to install a plugin for a different Elasticsearch version
Dec 14, 2020
pugnascotia
changed the title
Fix the warning when trying to install a plugin for a different Elasticsearch version
Fix warning when installing a plugin for different ESversion
Dec 14, 2020
Thanks for the fix @flyingpot! |
pugnascotia
pushed a commit
that referenced
this pull request
Dec 14, 2020
This commit change the warn message returned by elasticsearch-plugin list. The elasticsearch version of plugin is needed for comparison with current es version rather than the plugin version.
Backported to |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 14, 2020
* elastic/master: (33 commits) Add searchable snapshot cache folder to NodeEnvironment (elastic#66297) [DOCS] Add dynamic runtime fields to docs (elastic#66194) Add HDFS searchable snapshot integration (elastic#66185) Support canceling cross-clusters search requests (elastic#66206) Mute testCacheSurviveRestart (elastic#66289) Fix cat tasks api params in spec and handler (elastic#66272) Snapshot of a searchable snapshot should be empty (elastic#66162) [ML] DFA _explain API should not fail when none field is included (elastic#66281) Add action to decommission legacy monitoring cluster alerts (elastic#64373) move rollup_index param out of RollupActionConfig (elastic#66139) Improve FieldFetcher retrieval of fields (elastic#66160) Remove unsed fields in `RestAnalyzeAction` (elastic#66215) Simplify searchable snapshot CacheKey (elastic#66263) Autoscaling remove feature flags (elastic#65973) Improve searchable snapshot mount time (elastic#66198) [ML] Report cause when datafeed extraction encounters error (elastic#66167) Remove suggest reference in some API specs (elastic#66180) Fix warning when installing a plugin for different ESversion (elastic#66146) [ML] make `xpack.ml.max_ml_node_size` and `xpack.ml.use_auto_machine_memory_percent` dynamically settable (elastic#66132) [DOCS] Add `require_alias` to Bulk API (elastic#66259) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Core/Infra/Plugins
Plugin API and infrastructure
Team:Core/Infra
Meta label for core/infra team
v7.11.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit change the warn message returned by elasticsearch-plugin list. The elasticsearch version of plugin is needed for comparison with current es version rather than the plugin version.