Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x][Transform] Fix casting in ExceptionRootCauseFinder (#66123) #66150

Conversation

dimitris-athanasiou
Copy link
Contributor

Method getRootCauseException is checking whether the unwrapped
exception is an instance of SearchPhaseExecutionException but then
proceeds to cast the parent exception. This would lead to a casting
error. This commit fixes this and adds a unit test to guard it.

Backport of #66123

Method `getRootCauseException` is checking whether the unwrapped
exception is an instance of `SearchPhaseExecutionException` but then
proceeds to cast the parent exception. This would lead to a casting
error. This commit fixes this and adds a unit test to guard it.

Backport of elastic#66123
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@dimitris-athanasiou dimitris-athanasiou merged commit d82b892 into elastic:7.x Dec 10, 2020
@dimitris-athanasiou dimitris-athanasiou deleted the fix-casting-in-transform-root-cause-finder-7x branch December 10, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants