[Transform] Fix casting in ExceptionRootCauseFinder #66123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method `getRootCauseException` is checking whether the unwrapped exception is an instance of `SearchPhaseExecutionException` but then proceeds to cast the parent exception. This would lead to a casting error. This commit fixes this and adds a unit test to guard it.
|
Pinging @elastic/ml-core (:ml/Transform) |
hendrikmuhs
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
LGTM, good spot.
I did some research on the code, fortunately this case never happens, SearchPhaseExecutionException is never wrapped and never meant to be wrapped in a ElasticsearchWrapperException. Instead of checking unwrappedThrowable its also possible to check t and unwrap it, if its not a SPEE. However, it does not to hurt to do it this way.
|
I suggest to re-label it as |
dimitris-athanasiou
deleted the
fix-casting-in-transform-root-cause-finder
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Dec 10, 2020
Method `getRootCauseException` is checking whether the unwrapped exception is an instance of `SearchPhaseExecutionException` but then proceeds to cast the parent exception. This would lead to a casting error. This commit fixes this and adds a unit test to guard it. Backport of elastic#66123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
getRootCauseExceptionis checking whether the unwrappedexception is an instance of
SearchPhaseExecutionExceptionbut thenproceeds to cast the parent exception. This would lead to a casting
error. This commit fixes this and adds a unit test to guard it.