Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wraps timestamp values in quotes in preview_transforms YAML test #66046

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Wraps timestamp values in quotes in preview_transforms YAML test #66046

merged 1 commit into from
Dec 9, 2020

Conversation

picandocodigo
Copy link
Member

When timestamp values are not wrapped in quotes, the Ruby YAML parser errors when trying to parse this test. It would be great to find a way to validate these values in advance.

Related: #62153 #62468 #63543 #63661

@picandocodigo picandocodigo added :Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team labels Dec 8, 2020
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Dec 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

hendrikmuhs
hendrikmuhs approved these changes Dec 9, 2020
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I will try to remind myself the next time, however - as you said - it would be good if the java rest test runner is as strict as you require it for clients.

Mpdreamz
Mpdreamz approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can take a stab at preventing this in the Java parser so it's caught before it goes out.

@Mpdreamz
Copy link
Member

Mpdreamz commented Dec 9, 2020

I briefly investigated but nothing in the YamlParser hints to whether the string was quoted or not.

@picandocodigo picandocodigo merged commit 652b78f into elastic:master Dec 9, 2020
@picandocodigo picandocodigo deleted the wrap_values_in_quotes branch December 9, 2020 08:40
@picandocodigo picandocodigo mentioned this pull request Dec 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picandocodigo @elasticmachine @Mpdreamz @hendrikmuhs