Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds quotes to timestamp values in runtime_fields/40_date YAML test #62468

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Adds quotes to timestamp values in runtime_fields/40_date YAML test #62468

merged 1 commit into from
Sep 16, 2020

Conversation

picandocodigo
Copy link
Member

Pinging @nik9000 since you might have missed #62153.

Timestamp values without surrounding quotes make the client YAML parsers error.

@picandocodigo picandocodigo added :Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team labels Sep 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Sep 16, 2020
nik9000
nik9000 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one of our parsers isn't standard we should fix it. We could totally make the Java parser complain about such fields. But for now, if this fixes you, we should merge it.

@picandocodigo
Copy link
Member Author

@nik9000 Ruby's YAML parser has this error when the test files are being loaded in the Elasticsearch Ruby client's integration tests.

I'll merge this now, but if the format is ok for YAML I can look into different ways of parsing the test files to see if there's a way it doesn't error with this format.

@picandocodigo picandocodigo merged commit 0cfb3e9 into elastic:master Sep 16, 2020
@picandocodigo
Copy link
Member Author

Thanks @nik9000!

@picandocodigo picandocodigo deleted the add_quotes_runtime_fields_yaml_tests branch September 16, 2020 15:29
@picandocodigo picandocodigo mentioned this pull request Sep 17, 2020
Merged
@picandocodigo picandocodigo mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >non-issue Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picandocodigo @elasticmachine @nik9000 @jakelandis