Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary references to index version. #65402

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Remove unnecessary references to index version. #65402

merged 2 commits into from
Nov 24, 2020

Conversation

jtibshirani
Copy link
Contributor

@jtibshirani jtibshirani commented Nov 24, 2020 •
edited
Loading

  • Remove unnecessary references in mapping code.
  • Remove version from QueryAnalyzer#analyze.

Relates to #65399.

@jtibshirani jtibshirani added :Search Foundations/Mapping Index mappings, including merging and defining field types >refactoring v7.11.0 v8.0.0 labels Nov 24, 2020
@jtibshirani jtibshirani marked this pull request as ready for review November 24, 2020 01:28
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Nov 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

romseygeek
romseygeek approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm guessing that most of these are because we did need to check a Version in the 7x line but don't in 8x?

@jtibshirani
Copy link
Contributor Author

I'm guessing that most of these are because we did need to check a Version in the 7x line but don't in 8x?

This is true for the QueryAnalyzer change, but the others are unused in 7.x too!

@jtibshirani jtibshirani merged commit af2f084 into elastic:master Nov 24, 2020
@jtibshirani jtibshirani deleted the remove-version-checks branch November 24, 2020 16:25
@jtibshirani jtibshirani mentioned this pull request Nov 24, 2020
Merged
jtibshirani added a commit to jtibshirani/elasticsearch that referenced this pull request Nov 24, 2020
@jtibshirani
Remove unnecessary references to index version. (elastic#65402)
a581595 
* Remove unnecessary references in mapping code.
* Remove version from QueryAnalyzer#analyze.
@jtibshirani jtibshirani mentioned this pull request Dec 4, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
>refactoring :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtibshirani @elasticmachine @romseygeek @jakelandis