Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate index version checks #65399

Closed
1 of 3 tasks
jtibshirani opened this issue Nov 23, 2020 · 5 comments
Closed
1 of 3 tasks

Consolidate index version checks #65399

jtibshirani opened this issue Nov 23, 2020 · 5 comments
Labels
:Core/Infra/Settings Settings infrastructure and APIs Meta >refactoring :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Core/Infra Meta label for core/infra team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@jtibshirani
Copy link
Contributor

jtibshirani commented Nov 23, 2020

In order maintain compatibility with older indices, we sometimes need to check the index version and take special action. These index version checks happen in a variety of places and ways, making it hard to understand what logic depends on the index version. It also means that compatibility logic is scattered throughout various components, which hurts code quality.

It would be good to consolidate index version checks as much as possible. Some ideas:

@jtibshirani jtibshirani added :Search Foundations/Mapping Index mappings, including merging and defining field types :Core/Infra/Settings Settings infrastructure and APIs Meta >refactoring labels Nov 23, 2020
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Core/Infra Meta label for core/infra team labels Nov 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@icemakegirl
Copy link

I have a question, is this issue still open? apparently all the quest are done
I am a beginner Dev

@javanna
Copy link
Member

javanna commented Nov 30, 2023

I think we can close this, what do you think @rjernst ?

@rjernst
Copy link
Member

rjernst commented Dec 4, 2023

I agree, this can be closed. We now have IndexVersion which mostly satisfies the consolidation originally envisioned.

@rjernst rjernst closed this as completed Dec 4, 2023
@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Settings Settings infrastructure and APIs Meta >refactoring :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Core/Infra Meta label for core/infra team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Development

No branches or pull requests

5 participants