Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some progress on failing runtime fields tests #61098

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Some progress on failing runtime fields tests #61098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/20_terms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,36 @@ setup:

- match: { indices.test_1.total.fielddata.memory_size_in_bytes: 0}

---
"Global ordinals are loaded with the global_ordinals execution hint":

- do:
index:
refresh: true
index: test_1
id: 1
routing: 1
body: { "str": "abc" }

- do:
index:
refresh: true
index: test_1
id: 2
routing: 1
body: { "str": "abc" }

- do:
index:
refresh: true
index: test_1
id: 3
routing: 1
body: { "str": "bcd" }

- do:
indices.refresh: {}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only one test added here, so I don't follow what is being split. Also, would it make sense to make the test changes to master directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cutting this test in half.

I think it'd make sense to do this in master if we expected folks to hack on these tests before we merge this down. I'm mostly the person who I'd expect to hack on these tests so I don't think that is super likely.

- do:
search:
index: test_1
Expand Down
8 changes: 4 additions & 4 deletions x-pack/plugin/runtime-fields/qa/rest/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,17 @@ yamlRestTest {
[
/////// TO FIX ///////
'search/330_fetch_fields/*', // The whole API is not yet supported
'search.aggregation/20_terms/Global ordinals are not loaded with the map execution hint', // Broken. Gotta fix.
'search.highlight/40_keyword_ignore/Plain Highligher should skip highlighting ignored keyword values', // Broken. Gotta fix.
'search.highlight/40_keyword_ignore/Plain Highligher should skip highlighting ignored keyword values', // The plain highlighter is incompatible with runtime fields. Worth fixing?
'search/115_multiple_field_collapsing/two levels fields collapsing', // Broken. Gotta fix.
'search/140_pre_filter_search_shards/pre_filter_shard_size with shards that have no hit', // Broken. Gotta fix.
'field_caps/30_filter/Field caps with index filter', // We don't support filtering field caps on runtime fields. What should we do?
'search.aggregation/10_histogram/*', // runtime_script doesn't support sub-fields. Maybe it should?
/////// TO FIX ///////

/////// NOT SUPPORTED ///////
'search.aggregation/280_rare_terms/*', // Requires an index and we won't have it
'search.aggregation/20_terms/string profiler via global ordinals', // Runtime fields don't have global ords
// Runtime fields don't have global ords
'search.aggregation/20_terms/string profiler via global ordinals',
'search.aggregation/20_terms/Global ordinals are loaded with the global_ordinals execution hint',
/////// NOT SUPPORTED ///////
].join(',')
}