Some progress on failing runtime fields tests #61098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks apart the a test for the `terms` aggregation into one that work for runtime fields and one that doesn't.
nik9000
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
javanna
reviewed
Aug 13, 2020
|
|
||
| - do: | ||
| indices.refresh: {} | ||
|
|
There was a problem hiding this comment.
I see only one test added here, so I don't follow what is being split. Also, would it make sense to make the test changes to master directly?
There was a problem hiding this comment.
I'm cutting this test in half.
I think it'd make sense to do this in master if we expected folks to hack on these tests before we merge this down. I'm mostly the person who I'd expect to hack on these tests so I don't think that is super likely.
javanna
approved these changes
Aug 13, 2020
|
Thanks @javanna ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 13, 2020
… master) This breaks apart the a test for the `terms` aggregation into one that work for runtime fields and one that doesn't.
nik9000
added a commit
that referenced
this pull request
Aug 13, 2020
#61101) This breaks apart the a test for the `terms` aggregation into one that work for runtime fields and one that doesn't.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 13, 2020
… 7.x) This breaks apart the a test for the `terms` aggregation into one that work for runtime fields and one that doesn't.
nik9000
added a commit
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks apart the a test for the
termsaggregation into one thatwork for runtime fields and one that doesn't.