Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement toString for BulkByScrollTask #59042

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 5, 2020

We should implement "toString" of BulkByScrollTask.StatusOrException to have a meaningful log message when a reindex task completes.

@dnhatn dnhatn added >non-issue v8.0.0 :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down v7.9.0 labels Jul 5, 2020
@dnhatn dnhatn requested a review from nik9000 July 5, 2020 23:12
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Reindex)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 5, 2020
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@dnhatn
Copy link
Member Author

dnhatn commented Jul 6, 2020

Thanks Nik!

@dnhatn dnhatn merged commit cda2f9b into elastic:master Jul 6, 2020
@dnhatn dnhatn deleted the reindex-status branch July 6, 2020 02:05
dnhatn added a commit that referenced this pull request Jul 6, 2020
We should implement "toString" of BulkByScrollTask.StatusOrException 
to have a meaningful log message when a reindex task completes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants