Implement toString for BulkByScrollTask (#59042)

We should implement "toString" of BulkByScrollTask.StatusOrException to have a meaningful log message when a reindex task completes.
elastic · Jul 6, 2020 · 62763b1 · 62763b1
1 parent a9151db
commit 62763b1
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/server/src/main/java/org/elasticsearch/index/reindex/BulkByScrollTask.java b/server/src/main/java/org/elasticsearch/index/reindex/BulkByScrollTask.java
@@ -22,6 +22,7 @@
 import org.elasticsearch.ElasticsearchException;
 import org.elasticsearch.common.Nullable;
 import org.elasticsearch.common.ParseField;
+import org.elasticsearch.common.Strings;
 import org.elasticsearch.common.collect.Tuple;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
@@ -985,6 +986,15 @@ public static StatusOrException fromXContent(XContentParser parser) throws IOExc
             }
         }
 
+        @Override
+        public String toString() {
+            if (exception != null) {
+                return "BulkByScrollTask{error=" + Strings.toString(this) + "}";
+            } else {
+                return "BulkByScrollTask{status=" + Strings.toString(this) + "}";
+            }
+        }
+
         @Override
         public boolean equals(Object obj) {
             if (obj == null) {