Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.7] 7.x only REST specification fixes (#56736) #57167

Merged
merged 1 commit into from
May 26, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7.x only REST specification fixes (#56736)
Fixes for the REST specification specific to 7.x

* remove ignore "cat.thread_pool.json" and add the "" as valid option. #55984 deprecated this field since it these params here have no effect on this specific API
* remove ignore "indices.put_mapping.json" by adding the required / in the path to pass validation.
jakelandis committed May 26, 2020

Verified

This commit was signed with the committer’s verified signature.
jakelandis Jake Landis
commit 05686010c59b0611d5a80e973d16ea5e7d2e624b
5 changes: 0 additions & 5 deletions rest-api-spec/build.gradle
Original file line number Diff line number Diff line change
@@ -10,8 +10,3 @@ artifacts {
restSpecs(new File(projectDir, "src/main/resources/rest-api-spec/api"))
restTests(new File(projectDir, "src/main/resources/rest-api-spec/test"))
}

validateRestSpec {
ignore "cat.thread_pool.json"
ignore "indices.put_mapping.json"
}
Original file line number Diff line number Diff line change
@@ -127,7 +127,7 @@
}
},
{
"path":"{index}/_mappings",
"path":"/{index}/_mappings",
"methods":[
"PUT",
"POST"
2 changes: 1 addition & 1 deletion rest-api-spec/src/main/resources/schema.json
Original file line number Diff line number Diff line change
@@ -201,7 +201,7 @@
"type": "array",
"items": {
"type": "string",
"pattern": "^[a-zA-Z_]+$"
"pattern": "^\\d*|[a-zA-Z_]+$"
},
"title": "Valid options when type is an enum"
},