Fix bool query behaviour on null value
#56817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until 7.7 we used to ignore `null` values for `minimum_should_match` in `bool` queries. An internal refactoring has changed this so now we get a parsing error. While `null` should not a common value here, we should restore the old behaviour at least on the 7.x lines. Closes elastic#56812
cbuescher
added
>bug
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
fwiw I'm okay if we want to error on this in 8.0, in that case I'll leave a comment in the change notes but would port this back to open 7 branches. Also think accepting |
|
@romseygeek it was also just brought up on the issue that before 7.7 also |
romseygeek
approved these changes
May 26, 2020
cbuescher
pushed a commit
that referenced
this pull request
May 26, 2020
Until 7.7 we used to ignore `null` values for `bool`queries `minimum_should_match`, parameters and also for the `must`, `must_not`, `should` and `filter` clauses. An internal refactoring has changed this so now we get a parsing error. While `null` should not a common value here, we should restore the old behaviour for bwc for now. Closes #56812
cbuescher
pushed a commit
that referenced
this pull request
May 26, 2020
Until 7.7 we used to ignore `null` values for `bool`queries `minimum_should_match`, parameters and also for the `must`, `must_not`, `should` and `filter` clauses. An internal refactoring has changed this so now we get a parsing error. While `null` should not a common value here, we should restore the old behaviour for bwc for now. Closes #56812
cbuescher
pushed a commit
that referenced
this pull request
May 26, 2020
Until 7.7 we used to ignore `null` values for `bool`queries `minimum_should_match`, parameters and also for the `must`, `must_not`, `should` and `filter` clauses. An internal refactoring has changed this so now we get a parsing error. While `null` should not a common value here, we should restore the old behaviour for bwc for now. Closes #56812
cbuescher
changed the title
minimum_should_match behaviour on null valuebool query behaviour on null value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until 7.7 we used to ignore
nullvalues forminimum_should_matchinboolqueries. An internal refactoring has accidentally changed this so now we get a parsing error.
While
nullshould not be a common value here, we should restore the old behaviourat least on the 7.x lines.
Closes #56812