Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bool query parsing stricter #57154

Closed
cbuescher opened this issue May 26, 2020 · 2 comments
Closed

Make bool query parsing stricter #57154

cbuescher opened this issue May 26, 2020 · 2 comments
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team team-discuss

Comments

@cbuescher
Copy link
Member

A recent internal refactoring or our bool query parsing logic accidentally broke some edge case behaviour around ignoring null values
for several parameters like minimum_should_match or must, must_not, should or filter clauses were up until 7.7 we accepted queries like:

{
  "query": {
    "bool" : {
      "must" : null,
      "filter": {
        "term" : { "tag" : "tech" }
      }
  }
}

and ignored the null part. Although this usage seems to be rare, it lead to some issues so we restored the old behaviour. This is a follow up to discuss whether we want to remove this in 8.0 as a breaking change.

@cbuescher cbuescher added >enhancement :Search/Search Search-related issues that do not fall into other categories team-discuss labels May 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label May 26, 2020
@cbuescher
Copy link
Member Author

Discussed and decided we don't need to remove supporting "null" really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team team-discuss
Projects
None yet
Development

No branches or pull requests

2 participants