Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing IgnoredUnavailable Flag in 7.x SLM Retention Task #56616

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Missing IgnoredUnavailable Flag in 7.x SLM Retention Task
Without the flag we run into the situation where a broken repository (broken by some old 6.x
version of ES that is missing some snap-${uuid}.dat blobs fails to run the SLM retention task
since it always errors out).
original-brownbear committed May 12, 2020
commit b0a742070f8a35e4a6db97566b012acfecf23243
Original file line number Diff line number Diff line change
@@ -270,6 +270,7 @@ void getAllRetainableSnapshots(Collection<String> repositories, ActionListener<M
for (String repository : repositories) {
client.admin().cluster()
.prepareGetSnapshots(repository)
.setIgnoreUnavailable(true)
.execute(ActionListener.wrap(resp -> {
final Set<SnapshotState> retainableStates =
new HashSet<>(Arrays.asList(SnapshotState.SUCCESS, SnapshotState.FAILED, SnapshotState.PARTIAL));