Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing IgnoredUnavailable Flag in 7.x SLM Retention Task #56616

Merged

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented May 12, 2020

Without the flag we run into the situation where a broken repository (e.g. broken by some old 6.x
version of ES that is missing some snap-${uuid}.dat blobs fails to run the SLM retention task
since it always errors out).

This only affects 7.x, in master the flag is set correctly.

Without the flag we run into the situation where a broken repository (broken by some old 6.x
version of ES that is missing some snap-${uuid}.dat blobs fails to run the SLM retention task
since it always errors out).
@original-brownbear original-brownbear added >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management v7.8.0 v7.9.0 labels May 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 12, 2020
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks Lee!

@original-brownbear original-brownbear merged commit c104c9a into elastic:7.x May 12, 2020
@original-brownbear original-brownbear deleted the fix-broken-retention-7.x branch May 12, 2020 16:08
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request May 12, 2020
…c#56616)

Without the flag we run into the situation where a broken repository (broken by some old 6.x
version of ES that is missing some snap-${uuid}.dat blobs fails to run the SLM retention task
since it always errors out).
original-brownbear added a commit that referenced this pull request May 12, 2020
#56618)

Without the flag we run into the situation where a broken repository (broken by some old 6.x
version of ES that is missing some snap-${uuid}.dat blobs fails to run the SLM retention task
since it always errors out).
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request May 13, 2020
…c#56616)

Without the flag we run into the situation where a broken repository (broken by some old 6.x
version of ES that is missing some snap-${uuid}.dat blobs fails to run the SLM retention task
since it always errors out).
original-brownbear added a commit that referenced this pull request May 13, 2020
#56663)

Without the flag we run into the situation where a broken repository (broken by some old 6.x
version of ES that is missing some snap-${uuid}.dat blobs fails to run the SLM retention task
since it always errors out).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team v7.7.1 v7.8.0 v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants