Ensure unregister child node if failed to register task #56254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>non-issue
:Distributed Coordination/Task Management
|
Pinging @elastic/es-distributed (:Distributed/Task Management) |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
@elasticmachine test this please |
|
@elasticmachine update branch |
|
user doesn't have permission to update head repository |
|
Thanks Henning. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
May 6, 2020
We fail to unregister the child node in registerAndExecute if the parent task is being canceled. This leads to a bug where a cancel request never completes. Closes elastic#55875 Relates elastic#54312
dnhatn
added a commit
that referenced
this pull request
May 7, 2020
dnhatn
added a commit
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fail to unregister the child node in
registerAndExecuteif the parent task is being canceled. This leads to a bug where a cancel request never completes.Closes #55875
Relates #54312
I labelled this non-issue for an unreleased bug in #54312.