Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] org.elasticsearch.action.admin.cluster.node.tasks.CancellableTasksIT.testDoNotWaitForCompletion #55875

Closed
not-napoleon opened this issue Apr 28, 2020 · 4 comments · Fixed by #56254
Closed

[CI] org.elasticsearch.action.admin.cluster.node.tasks.CancellableTasksIT.testDoNotWaitForCompletion #55875

not-napoleon opened this issue Apr 28, 2020 · 4 comments · Fixed by #56254
Assignees
@dnhatn
Labels
:Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI

Comments

@not-napoleon
Copy link
Member

This failed on 7.x with a time out.

Build scan: https://gradle-enterprise.elastic.co/s/4slsedxex4eei

Repro line:

./gradlew ':server:integTest' --tests "org.elasticsearch.action.admin.cluster.node.tasks.CancellableTasksIT.testDoNotWaitForCompletion" -Dtests.seed=8B437416A10AF044 -Dtests.security.manager=true -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dtests.locale=be -Dtests.timezone=Africa/Algiers -Dcompiler.java=14 -Druntime.java=8
@not-napoleon not-napoleon added >test-failure Triaged test failures from CI :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. labels Apr 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Task Management)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Apr 28, 2020
@dnhatn dnhatn assigned dnhatn and unassigned dnhatn Apr 28, 2020
@dnhatn dnhatn mentioned this issue Apr 29, 2020
Merged
dnhatn added a commit that referenced this issue Apr 29, 2020
@dnhatn
Add trace log for task cancellation (#55940)
2fa9988 
Adding trace logs to the task cancellation and its tests 
to debug the test failure in #55875.

Relates ##55875
dnhatn added a commit that referenced this issue Apr 29, 2020
@dnhatn
Add trace log for task cancellation (#55940)
edbaa19 
Adding trace logs to the task cancellation and its tests 
to debug the test failure in #55875.

Relates ##55875
@mark-vieira
Copy link
Contributor

I've muted this in master and 7.x (failing in both).

I just now noticed that @dnhatn has added some additional logging here though. Please feel free to unmute if you need to capture more info, but let's try and remute quickly since this is failing several times a day.

@dnhatn
Copy link
Member

dnhatn commented Apr 29, 2020

Sure, thanks for the ping @mark-vieira.

@dnhatn
Copy link
Member

dnhatn commented May 2, 2020

Log: log.txt

@dnhatn dnhatn mentioned this issue May 5, 2020
Merged
dnhatn added a commit that referenced this issue May 6, 2020
@dnhatn
Ensure unregister child node if failed to register task (#56254)
7b799c6 
We fail to unregister the child node in registerAndExecute if the parent 
task is being canceled. This leads to a bug where a cancel request never
completes.

Closes #55875
Relates #54312
@dnhatn dnhatn mentioned this issue May 6, 2020
Merged
dnhatn added a commit to dnhatn/elasticsearch that referenced this issue May 6, 2020
@dnhatn
Ensure unregister child node if failed to register task (elastic#56254)
32f8d65 
We fail to unregister the child node in registerAndExecute if the parent
task is being canceled. This leads to a bug where a cancel request never
completes.

Closes elastic#55875
Relates elastic#54312
@dnhatn dnhatn mentioned this issue May 6, 2020
Merged
dnhatn added a commit that referenced this issue May 7, 2020
@dnhatn
Ensure unregister child node if failed to register task (#56254)
165e9a4 
We fail to unregister the child node in registerAndExecute if the parent
task is being canceled. This leads to a bug where a cancel request never
completes.

Closes #55875
Relates #54312
dnhatn added a commit that referenced this issue May 7, 2020
@dnhatn
Ensure unregister child node if failed to register task (#56254)
bd0e0f4 
We fail to unregister the child node in registerAndExecute if the parent
task is being canceled. This leads to a bug where a cancel request never
completes.

Closes #55875
Relates #54312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
:Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure unregister child node if failed to register task dnhatn/elasticsearch
4 participants
@not-napoleon @mark-vieira @dnhatn @elasticmachine