Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geo_bounds aggregation support for geo_shape #55328

Merged
merged 9 commits into from
Apr 22, 2020
Merged

Add geo_bounds aggregation support for geo_shape #55328

merged 9 commits into from
Apr 22, 2020

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Apr 16, 2020

This PR adds a new GeoShapeBoundsAggregator to the spatial plugin and registers it with the GeoShapeValuesSourceType.

@talevy talevy added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Apr 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@talevy talevy requested a review from iverase April 17, 2020 01:03
iverase
iverase approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you can review the visibility of some classes but in general ready to go.

server/src/main/java/org/elasticsearch/search/aggregations/metrics/GeoBoundsAggregator.java Outdated Show resolved Hide resolved
@talevy
Copy link
Contributor Author

talevy commented Apr 22, 2020

run elasticsearch-ci/2

@talevy
Copy link
Contributor Author

talevy commented Apr 22, 2020

thanks Ignacio!

@talevy talevy merged commit 4431ed7 into elastic:master Apr 22, 2020
@talevy talevy deleted the geo_bounds2 branch April 22, 2020 15:12
@talevy talevy mentioned this pull request Apr 22, 2020
Merged
talevy added a commit that referenced this pull request Apr 22, 2020
@talevy
[backport] Add geo_bounds aggregation support for geo_shape (#55328) (#…
f27ce69 
…55600)

This commit adds a new GeoShapeBoundsAggregator to the spatial plugin and registers it with the GeoShapeValuesSourceType. This enables geo_bounds aggregations on geo_shape fields
@nreese nreese mentioned this pull request Apr 23, 2020
Closed
@talevy talevy mentioned this pull request Apr 29, 2020
Closed
@talevy talevy mentioned this pull request May 8, 2020
Closed
@jomach
Copy link

jomach commented May 19, 2020

@giladgal when is going 7.8 to be release ? I think I need this fix.
Will Kibana Maps support this too or does it need to be fixed too?

@giladgal
Copy link
Contributor

@jomach we have released 7.7 on 13-May-2020 so you can roughly guestimate that it is coming in the near future, but we do not commit to specific release dates since by maintaining the flexibility to change the release date (and content) we are able to better balance quality and a rapid release cycle. Kibana Maps is tentatively planned to support geo bounds aggregations on shape when it is released in Elasticsearch and [Maps] geo_shape fit to bounds #64303 is the relevant issue to follow for that, but note that indices created prior to 7.8 will have to be re-indexed to enable doc_values for the geo_shape field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst left review comments

@iverase iverase iverase approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >feature release highlight v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@talevy @elasticmachine @jomach @giladgal @rjernst @iverase @jakelandis