Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute test in versions that do not support pwd protected keystores #55069

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Mute test in versions that do not support pwd protected keystores #55069

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02d621d
Mute test in versions that do not support pwd protected keystores
jkakavas Apr 10, 2020
772287c
fix version in mute
jkakavas Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...-api-spec/src/main/resources/rest-api-spec/test/nodes.reload_secure_settings/10_basic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
---
"node_reload_secure_settings test wrong password":
- skip:
version: " - 7.9.99"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will adjust this to 7.6.99 once #55060 and #55059 are merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll want to make the version here 7.99.99 otherwise this will start failing when we branch for 7.10.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well @mark-vieira , 7.10 will have the changes so it would be safe to run this against it ( as said I will adjust this to 7.6.99 within the next couple of hours )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, if we plan to backport soon then disregard.

reason: "support for reloading password protected keystores was introduced in 8.0.0"

- do:
nodes.reload_secure_settings:
Expand Down