Mute test in versions that do not support pwd protected keystores #55069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkakavas
commented
Apr 10, 2020
| @@ -1,5 +1,8 @@ | |||
| --- | |||
| "node_reload_secure_settings test wrong password": | |||
| - skip: | |||
| version: " - 7.9.99" | |||
There was a problem hiding this comment.
I think you'll want to make the version here 7.99.99 otherwise this will start failing when we branch for 7.10.
There was a problem hiding this comment.
well @mark-vieira , 7.10 will have the changes so it would be safe to run this against it ( as said I will adjust this to 7.6.99 within the next couple of hours )
There was a problem hiding this comment.
Ah, if we plan to backport soon then disregard.
mark-vieira
requested changes
Apr 10, 2020
| @@ -1,5 +1,8 @@ | |||
| --- | |||
| "node_reload_secure_settings test wrong password": | |||
| - skip: | |||
| version: " - 7.9.99" | |||
There was a problem hiding this comment.
I think you'll want to make the version here 7.99.99 otherwise this will start failing when we branch for 7.10.
mark-vieira
approved these changes
Apr 10, 2020
This was referenced May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.