Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting: Increase ingest script cache defaults #53765

Conversation

stu-elastic
Copy link
Contributor

@stu-elastic stu-elastic commented Mar 18, 2020

  • Adds ability for contexts to specify their own defaults.

  • Context defaults are applied if no context-specific or
    general setting exists.

  • See 070ea7e for settings keys.

  • Increases the per-context default for the ingest context.

    • Cache size is doubled, 200 compared to default of 100
    • Cache expiration is unchanged at no expiration
    • Cache max compilation is quintupled, 375/5m instead of 75/5m

Refs: #50152

* Adds ability for contexts to specify their own defaults.
* Context defaults are applied if no context-specific or
  general setting exists.
* See 070ea7e for settings keys.

* Increases the per-context default for the `ingest` context.
* Cache size is doubled, 200 compared to default of 100
* Cache expiration is unchanged at no expiration
* Cache max compilation is quintupled, 375/5m instead of 75/5m

Refs: elastic#50152
@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 labels Mar 18, 2020
@stu-elastic stu-elastic requested review from rjernst and jdconrad March 18, 2020 20:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding defaults.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional context i think we need changed, otherwise LGTM

@stu-elastic stu-elastic merged commit 1b37d4b into elastic:master Mar 20, 2020
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this pull request Mar 20, 2020
* Adds ability for contexts to specify their own defaults.
* Context defaults are applied if no context-specific or
  general setting exists.
* See 070ea7e for settings keys.

* Increases the per-context default for the `ingest` context.
  * Cache size is doubled, 200 compared to default of 100
  * Cache expiration is unchanged at no expiration
  * Cache max compilation is quintupled, 375/5m instead of 75/5m

Refs: elastic#50152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants