-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripting: Increase ingest script cache defaults #53765
Merged
stu-elastic
merged 3 commits into
elastic:master
from
stu-elastic:fix/50152-painless-limit-per-context__03__per_context_defaults
Mar 20, 2020
Merged
Scripting: Increase ingest script cache defaults #53765
stu-elastic
merged 3 commits into
elastic:master
from
stu-elastic:fix/50152-painless-limit-per-context__03__per_context_defaults
Mar 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds ability for contexts to specify their own defaults. * Context defaults are applied if no context-specific or general setting exists. * See 070ea7e for settings keys. * Increases the per-context default for the `ingest` context. * Cache size is doubled, 200 compared to default of 100 * Cache expiration is unchanged at no expiration * Cache max compilation is quintupled, 375/5m instead of 75/5m Refs: elastic#50152
stu-elastic
added
>enhancement
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
v8.0.0
labels
Mar 18, 2020
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
jdconrad
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding defaults.
rjernst
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One additional context i think we need changed, otherwise LGTM
…152-painless-limit-per-context__03__per_context_defaults
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Mar 20, 2020
* Adds ability for contexts to specify their own defaults. * Context defaults are applied if no context-specific or general setting exists. * See 070ea7e for settings keys. * Increases the per-context default for the `ingest` context. * Cache size is doubled, 200 compared to default of 100 * Cache expiration is unchanged at no expiration * Cache max compilation is quintupled, 375/5m instead of 75/5m Refs: elastic#50152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
>enhancement
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability for contexts to specify their own defaults.
Context defaults are applied if no context-specific or
general setting exists.
See 070ea7e for settings keys.
Increases the per-context default for the
ingest
context.Refs: #50152