Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Ingest to use submit several scripts in one request without thrashing #53896

Closed
stu-elastic opened this issue Mar 20, 2020 · 2 comments
Closed

Allow Ingest to use submit several scripts in one request without thrashing #53896

stu-elastic opened this issue Mar 20, 2020 · 2 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

Ingest can use many small scripts in a single request, these may cause thrashing and trip compilation limits.

We've increased defaults for these contexts to mitigate the problem, see: #53765 but that is a workaround, not a solution.

We should figure out a way to keep the safety of compilation limits and the performance of compilation caching without thrash when a single request uses many small scripts.
@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Mar 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@stu-elastic stu-elastic mentioned this issue Mar 20, 2020
Merged
@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@stu-elastic
Copy link
Contributor Author

Scripts are eagerly compiled and there's not compilation limits in ingest. This is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rjernst @elasticmachine @stu-elastic