Remove the top-level 'mapping type' section. #53374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-search (:Search/Mapping) |
|
@elasticmachine run elasticsearch-ci/docs |
|
The build is failing because of a cross-document reference in es-hadoop. I opened elastic/elasticsearch-hadoop#1440 to remove it. |
romseygeek
approved these changes
Mar 11, 2020
|
@elasticmachine run elasticsearch-ci/docs |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed confusing for users that our top-level mapping page still had a
prominent section named 'Mapping Type'. I've reworked the docs to remove this
reference and add a note about types removal (similar to the note we added to
other APIs like put mapping).