Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to 'mapping type' section. #1440

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Conversation

jtibshirani
Copy link
Contributor

Since mapping types are being removed, I've opened a PR in the elasticsearch
repo to remove this section: elastic/elasticsearch#53374.

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@romseygeek
Copy link

Is this OK to merge despite the CI failures above @jbaiera ?

@jbaiera
Copy link
Member

jbaiera commented Mar 17, 2020

Yes, the CI for the project is broken at the moment.

@romseygeek romseygeek merged commit 0afe366 into master Mar 17, 2020
romseygeek pushed a commit that referenced this pull request Mar 17, 2020
These pages are being removed in the mainline docs due to the removal
of types as a whole.
@jbaiera jbaiera deleted the docs/mapping-type branch March 17, 2020 19:17
jtibshirani added a commit that referenced this pull request Mar 23, 2020
These pages are being removed in the mainline docs due to the removal
of types as a whole.
jtibshirani added a commit that referenced this pull request Mar 23, 2020
These pages are being removed in the mainline docs due to the removal
of types as a whole.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants