Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformat stop token filter #53059

Merged
merged 2 commits into from
Mar 3, 2020
Merged

[DOCS] Reformat stop token filter #53059

merged 2 commits into from
Mar 3, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Mar 3, 2020

Makes the following changes to the stop token filter docs:

  • Updates description
  • Adds a link to the related Lucene filter
  • Adds detailed analyze snippet
  • Updates custom analyzer and custom filter snippets
  • Adds a list of predefined stop words by language

Closes #16561.

Makes the following changes to the `stop` token filter docs:

* Updates description
* Adds a link to the related Lucene filter
* Adds detailed analyze snippet
* Updates custom analyzer and custom filter snippets
* Adds a list of predefined stop words by language

Co-authored-by: ScottieL <[email protected]>
@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens labels Mar 3, 2020
@jrodewig jrodewig requested a review from romseygeek March 3, 2020 15:37
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise

+
--
(Optional, string or array of strings)
Language value, such as `_arabic_` or `thai`. Defaults to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/thai/_thai_/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@jrodewig jrodewig merged commit e016864 into elastic:master Mar 3, 2020
@jrodewig jrodewig deleted the docs__reformat-stop-tokenfilter branch March 3, 2020 18:05
jrodewig added a commit that referenced this pull request Mar 3, 2020
Makes the following changes to the `stop` token filter docs:

* Updates description
* Adds a link to the related Lucene filter
* Adds detailed analyze snippet
* Updates custom analyzer and custom filter snippets
* Adds a list of predefined stop words by language

Co-authored-by: ScottieL <[email protected]>
jrodewig added a commit that referenced this pull request Mar 3, 2020
Makes the following changes to the `stop` token filter docs:

* Updates description
* Adds a link to the related Lucene filter
* Adds detailed analyze snippet
* Updates custom analyzer and custom filter snippets
* Adds a list of predefined stop words by language

Co-authored-by: ScottieL <[email protected]>
@jrodewig
Copy link
Contributor Author

jrodewig commented Mar 3, 2020

Backport commits

master e016864
7.x cf87724
7.6 c46c628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/Analysis How text is split into tokens v7.6.2 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No documentation on what stopwords are in each set
4 participants