Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Added supported stopword languages. Closes elastic#16561 #48011

Closed
wants to merge 11 commits into from

Conversation

ScottieL
Copy link
Contributor

@williamrandolph williamrandolph added :Search Relevance/Analysis How text is split into tokens >docs General docs changes labels Oct 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution @ScottieL. I left a few comments for needed changes. Let me know if you have any questions.

Copy link
Contributor Author

@ScottieL ScottieL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I figured I added a little much but wanted to be thorough.

@jrodewig
Copy link
Contributor

Hi @ScottieL

Before moving forward, can you address this comment:
https://github.com/elastic/elasticsearch/pull/48011/files#r334672652

I think it may be helpful to link to the stopwords list in Lucene where applicable. I included an example for Arabic below.

Those changes are pretty substantive, but I believe they're important to users. The current links require a bit more work to find the actual stopwords.

Copy link
Contributor Author

@ScottieL ScottieL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stopword list locations updated

Cleaned up some references, most of these should now directly link you to the list of stopwords for that particular language. If not, they will link you to the portion of code in which the list is invoked. I had trouble finding the actual stopwords list for CJK.
@jrodewig
Copy link
Contributor

@elascticmachine test this please

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is almost ready for merge. I left some additional suggestions.

I feel I led you astray with my example link. While the files are identical in most cases, we should link to the Lucene source files rather than the Solr example files where possible. My example was the latter. My apologies for the mistake.

Thanks again for your work on this PR.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is almost ready for merge. I left some additional suggestions. When done, I'll ask an engineer to review.

I feel I led you astray with my example link. While the files are identical in most cases, we should link to the Lucene source files rather than the Solr example files where possible. My example was the latter. My apologies for the mistake.

Thanks again for your work on this PR.

@jrodewig jrodewig removed the v8.0.0 label Mar 3, 2020
@jrodewig
Copy link
Contributor

jrodewig commented Mar 3, 2020

Superseded by #53059.

@jrodewig jrodewig closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/Analysis How text is split into tokens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants