-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Added supported stopword languages. Closes elastic#16561 #48011
Conversation
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-search (:Search/Analysis) |
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution @ScottieL. I left a few comments for needed changes. Let me know if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I figured I added a little much but wanted to be thorough.
…rt.asciidoc Co-Authored-By: James Rodewig <[email protected]>
…rt.asciidoc Co-Authored-By: James Rodewig <[email protected]>
…rt.asciidoc Co-Authored-By: James Rodewig <[email protected]>
…rt.asciidoc Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
…rt.asciidoc Co-Authored-By: James Rodewig <[email protected]>
Hi @ScottieL Before moving forward, can you address this comment:
Those changes are pretty substantive, but I believe they're important to users. The current links require a bit more work to find the actual stopwords. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopword list locations updated
Cleaned up some references, most of these should now directly link you to the list of stopwords for that particular language. If not, they will link you to the portion of code in which the list is invoked. I had trouble finding the actual stopwords list for CJK.
@elascticmachine test this please |
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is almost ready for merge. I left some additional suggestions.
I feel I led you astray with my example link. While the files are identical in most cases, we should link to the Lucene source files rather than the Solr example files where possible. My example was the latter. My apologies for the mistake.
Thanks again for your work on this PR.
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is almost ready for merge. I left some additional suggestions. When done, I'll ask an engineer to review.
I feel I led you astray with my example link. While the files are identical in most cases, we should link to the Lucene source files rather than the Solr example files where possible. My example was the latter. My apologies for the mistake.
Thanks again for your work on this PR.
docs/reference/analysis/analyzers/stop-analyzer-language-support.asciidoc
Show resolved
Hide resolved
Superseded by #53059. |
Yes
Yes
gradle check
?N/A
Yes
N/A
N/A