Test case for windows service where JAVA_HOME path contains spaces #53028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We lacked test coverage for the case where the path to Java contained special characters; this commit adds it.
williamrandolph
added
>non-issue
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
rjernst
approved these changes
Mar 2, 2020
|
That's funny. I forgot to update this branch to include the commit that would make these new tests pass. So I guess that helps confirm that these tests do in fact check what they're supposed to check. |
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Mar 3, 2020
…lastic#53028) * Test case where JAVA_HOME path contains spaces We lacked test coverage for the case where the path to Java contained special characters; this commit adds it. * Apply spotless formatting * Only test changing JDK paths on jdk builds * Remove unused import
williamrandolph
added a commit
that referenced
this pull request
Mar 3, 2020
… (#53057) * Handle special chars in JAVA_HOME in elasticsearch-service.bat (#52676) * Test case for windows service where JAVA_HOME path contains spaces (#53028) Co-authored-by: Muhammad Shaheer Akram <[email protected]>
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Mar 5, 2020
…ic#52676) (elastic#53057) * Handle special chars in JAVA_HOME in elasticsearch-service.bat (elastic#52676) * Test case for windows service where JAVA_HOME path contains spaces (elastic#53028) Co-authored-by: Muhammad Shaheer Akram <[email protected]>
williamrandolph
added a commit
that referenced
this pull request
Mar 5, 2020
… (#53057) (#53141) * Handle special chars in JAVA_HOME in elasticsearch-service.bat (#52676) * Test case for windows service where JAVA_HOME path contains spaces (#53028) Co-authored-by: Muhammad Shaheer Akram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lacked test coverage for the case where the path to Java contained special characters; this commit adds it. This missing case was exposed by #52676.