Handle special characters and spaces in JAVA_HOME path in elasticsearch-service.bat #52676
Conversation
|
💚 CLA has been signed |
gwbrown
added
the
:Delivery/Packaging
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
|
@rjernst Can you find someone to test and review this? I suspect if this change is right, a similar change is needed in the non-service batch script. |
rjernst
requested review from
williamrandolph
and removed request for
jasontedor
|
@jasontedor I'm still reviewing, but it looks like we already made this change to |
|
@williamrandolph Awesome, thanks for pointing that out. |
|
@shaheerakr I'd like to be able to merge this PR. Are you able to sign the Contributor License Agreement? |
|
@williamrandolph I have signed the Contributor licence agreement but somehow it is not updating here |
|
@williamrandolph Contributor Licence Agreement is updated here, you can merge now |
|
@elasticmachine test this please |
|
@elasticmachine run elasticsearch-ci/2 |
williamrandolph
changed the title
|
@williamrandolph are these changes ready to be merged or do i need to change anything for this unsuccessful test? |
|
@shaheerakr The failing test looks like the issue from #52364, and I don't believe it has anything to do with your commit. I'll try running the test again to see if it passes. @elasticmachine please run elasticsearch-ci/bwc |
|
@elasticmachine please run elasticsearch-ci/bwc |
|
I don't believe the failing test could have had anything to do with this code, so I've gone ahead and merged. The packaging tests have passed. |
… (#53057) * Handle special chars in JAVA_HOME in elasticsearch-service.bat (#52676) * Test case for windows service where JAVA_HOME path contains spaces (#53028) Co-authored-by: Muhammad Shaheer Akram <[email protected]>
|
@shaheerakr Thanks again for finding and fixing this issue. We appreciate the contribution. |
|
no problem @williamrandolph these changes will be available from 7.6.2 right? |
…ic#52676) (elastic#53057) * Handle special chars in JAVA_HOME in elasticsearch-service.bat (elastic#52676) * Test case for windows service where JAVA_HOME path contains spaces (elastic#53028) Co-authored-by: Muhammad Shaheer Akram <[email protected]>
… (#53057) (#53141) * Handle special chars in JAVA_HOME in elasticsearch-service.bat (#52676) * Test case for windows service where JAVA_HOME path contains spaces (#53028) Co-authored-by: Muhammad Shaheer Akram <[email protected]>
|
@shaheerakr Yes, the changes will now be in the next 7.6.x release as well as in 7.7.x. |
I was unable to install elasticsearch service, due to the following issue
The batch script was not able to parse the JAVA_HOME path correctly if there was a space in it, which is the case shown above as JAVA_HOME is set to C:\Program Files (x86)\jdk-12.0.2