Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds cat datafeeds API #52738

Merged
merged 3 commits into from
Feb 26, 2020
Merged

[DOCS] Adds cat datafeeds API #52738

merged 3 commits into from
Feb 26, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 25, 2020

@lcawl lcawl added >docs General docs changes :ml Machine learning v8.0.0 v7.7.0 labels Feb 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@lcawl
Copy link
Contributor Author

lcawl commented Feb 25, 2020

@elasticmachine update branch

@lcawl lcawl requested a review from benwtrent February 25, 2020 17:22
`search.bucket_avg`::
include::{docdir}/ml/ml-shared.asciidoc[tag=search-bucket-avg]
+
To retrieve this information, specify the `sba` or `bucketTimeMin` column in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. The API is also wrong as well. I will correct in a PR. Then we can correct it here :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @benwtrent ! I've made that change

@lcawl lcawl merged commit 42fbca7 into elastic:master Feb 26, 2020
@lcawl lcawl deleted the cat-datafeeds branch February 26, 2020 17:20
lcawl added a commit that referenced this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants