-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] add GET _cat/ml/datafeeds #51500
[ML] add GET _cat/ml/datafeeds #51500
Conversation
Pinging @elastic/ml-core (:ml) |
if (Strings.isNullOrEmpty(datafeedId)) { | ||
datafeedId = GetDatafeedsStatsAction.ALL; | ||
} | ||
GetDatafeedsStatsAction.Request request = new GetDatafeedsStatsAction.Request(datafeedId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was GetDatafeeds
not stats but stats makes a lot more sense 👍. I suppose naming the endpoint _cat/ml/datafeeds_stats
isn't great. All good here.
"required":false, | ||
"description":"Whether to ignore if a wildcard expression matches no datafeeds. (This includes `_all` string or when no datafeeds have been specified)" | ||
}, | ||
"bytes":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any byte units returned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think so, these options are a catch all as these parameters come by default with _cat APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a default size
parameter https://www.elastic.co/guide/en/elasticsearch/reference/current/cat.html that is only used by cat thread pool
My preference would be to remove this but it's not a deal breaker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"required":false, | ||
"description":"Whether to ignore if a wildcard expression matches no datafeeds. (This includes `_all` string or when no datafeeds have been specified)" | ||
}, | ||
"bytes":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a default size
parameter https://www.elastic.co/guide/en/elasticsearch/reference/current/cat.html that is only used by cat thread pool
My preference would be to remove this but it's not a deal breaker
@elasticmachine update branch |
This adds GET _cat/ml/datafeeds && _cat/ml/datafeeds/{datafeed_id}
Documentation added in #52738 |
This adds GET _cat/ml/datafeeds && _cat/ml/datafeeds/{datafeed_id}
Example calls
closes #51411