Geo shape query vs geo point #52382
Merged
Geo shape query vs geo point #52382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 15, 2019 19:05
in Class org.elasticsearch.search.geo.GeoPointShapeQueryTests
…tion raised, see org.elasticsearch.index.query.QueryShardContext.toQuery
in GeoPointShapeQueryTests
…ShapeQueryTests.java
GeoShapeQueryTests refactored adding superclass and sibling to accomodate new test coverage as part of adaptation of geo_shape query to work on geo_point fields
iverase
reviewed
Mar 14, 2020
server/src/main/java/org/elasticsearch/index/mapper/AbstractSearchableGeometryFieldType.java
Outdated
Show resolved
Hide resolved
…GeometryFieldType
nknize
suggested changes
Mar 17, 2020
There was a problem hiding this comment.
Looking good! A couple thoughts:
- We need to add testing for
GeometryCollection; but this can come in a follow up PR ShapeQueryBuilder.validateContentTypesreturns a newListinstance every time it's called. We need to be careful there. We already called it twice inbuildShapeQueryso that needs to be changed in this PR. We should probably make a static variable in the derived builders that call this once so we don't shoot ourselves in the foot in the future.
server/src/test/java/org/elasticsearch/index/query/GeoShapeQueryBuilderGeoPointTests.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/query/GeoShapeQueryBuilderGeoShapeTests.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/geo/GeoPointShapeQueryTests.java
Show resolved
Hide resolved
...gin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/query/ShapeQueryBuilder.java
Outdated
Show resolved
Hide resolved
...gin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/query/ShapeQueryBuilder.java
Show resolved
Hide resolved
…atial/index/query/ShapeQueryBuilder.java Co-Authored-By: Nick Knize <[email protected]>
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine update branch |
djptek
added a commit
to djptek-legacy/elasticsearch
that referenced
this pull request
Mar 18, 2020
Enable geo_shape query to work on geo_point fields for shapes: circle, polygon, multipolygon, rectangle see: elastic#48928 Co-Authored-By: @iverase
This was referenced Jan 18, 2021
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable geo_shape query to work on geo_point fields for shapes: circle, polygon, multipolygon, rectangle
see: #48928
many thanks to @iverase for fa64b52