Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable geo_shape queries on geo_point field types #48928

Closed
djptek opened this issue Nov 10, 2019 · 7 comments
Closed

Enable geo_shape queries on geo_point field types #48928

djptek opened this issue Nov 10, 2019 · 7 comments
Assignees
@djptek
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes WIP

Comments

@djptek
Copy link
Contributor

djptek commented Nov 10, 2019

Enable geo_shape query to work on geo_point fields. Add a new query processor for lon, lat point queries and modify the field mapper to accommodate add a new geo_shape mapper.
@djptek djptek added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Nov 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@djptek
Copy link
Contributor Author

djptek commented Nov 13, 2019

working on this

@nreese
Copy link
Contributor

nreese commented Nov 18, 2019 •
edited
Loading

Hi @djptek, wanting to check the status of adding geo_shape query support for geo_point fields. Is this feature targeting 7.6?

Kibana allows users to create filters from shapes in the UI. Those filters are placed in the URL. Having to put the shape geometry into the URL can cause the URLs to be too long and prevents users from creating filters from shapes with too many vertices when querying against geo_point fields. This is a large limitation. It is also a complex error to explain to users. Allowing pre-indexed shape query for geo_point fields would greatly simplify our messaging and allow filtering to work for any shape already indexed in ES and provide good messaging to users when shape is not indexed in ES.

cc @elastic/kibana-gis

@nreese
Copy link
Contributor

nreese commented Nov 18, 2019 •
edited
Loading

Here is a link to a related ES issue regarding pre-indexed query support for geo_points, #46730, for some more background

@polyfractal polyfractal removed the 7x label Dec 12, 2019
@djptek djptek mentioned this issue Jan 8, 2020
Merged
@djptek
Copy link
Contributor Author

djptek commented Jan 8, 2020

PR submitted for preliminary refactor post type-removal rework #50737 now working on query processor

@djptek djptek mentioned this issue Feb 14, 2020
Merged
@djptek djptek mentioned this issue Mar 17, 2020
Closed
@jpountz jpountz mentioned this issue Mar 17, 2020
Closed
22 tasks
djptek added a commit that referenced this issue Mar 18, 2020
@djptek
Geo shape query vs geo point (#52382)
d1cbdfb 
Enable geo_shape query to work on geo_point fields for shapes: circle, polygon, multipolygon, rectangle

see: #48928

Co-Authored-By:  @iverase
djptek added a commit to djptek-legacy/elasticsearch that referenced this issue Mar 18, 2020
@djptek
Geo shape query vs geo point (elastic#52382)
7dd0193 
Enable geo_shape query to work on geo_point fields for shapes: circle, polygon, multipolygon, rectangle

see: elastic#48928

Co-Authored-By:  @iverase
djptek added a commit that referenced this issue Mar 19, 2020
@djptek
Geo shape query vs geo point backport (#53774)
b0884ba 
Backport to 7x

Enable geo_shape query to work on geo_point fields for shapes: circle, polygon, multipolygon, rectangle see: #48928
Co-Authored-By:  @iverase
@djptek
Copy link
Contributor Author

djptek commented Mar 20, 2020

This issue now resolved, see PRs
#53774
#52382

@djptek djptek closed this as completed Mar 20, 2020
@alexfrancoeur
Copy link

🎉 🎉 🎉 🎉 🎉

This was referenced Mar 23, 2020
Closed
Closed
@iverase iverase mentioned this issue Apr 2, 2020
Closed
@iverase iverase mentioned this issue Oct 27, 2020
Merged
This was referenced Feb 9, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djptek djptek

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes WIP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nreese @nknize @polyfractal @djptek @elasticmachine @alexfrancoeur