Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always test against default distribution when in a FIPS JVM #51273

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Always test against default distribution when in a FIPS JVM #51273

merged 3 commits into from
Jan 22, 2020

Conversation

mark-vieira
Copy link
Contributor

Running with a FIPS JVM is only supported when using the default distribution, therefore, it doesn't make sense for us to test against the integ-test or OSS distributions when FIPS mode is enabled.

Closes #50364

@mark-vieira mark-vieira added v7.7.0 v8.0.0 :Delivery/Build Build or test infrastructure labels Jan 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@mark-vieira
Copy link
Contributor Author

@elasticmachine update branch

rjernst
rjernst approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/examples/painless-whitelist/build.gradle Outdated Show resolved Hide resolved
jkakavas
jkakavas approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-vieira mark-vieira merged commit e34d7fd into master Jan 22, 2020
@mark-vieira mark-vieira deleted the force-default-distro-fips branch January 22, 2020 19:01
mark-vieira added a commit that referenced this pull request Jan 22, 2020
@mark-vieira
Always test against default distribution when in a FIPS JVM (#51273)
6379899 
(cherry picked from commit e34d7fd)
mark-vieira added a commit that referenced this pull request Jan 22, 2020
@mark-vieira
Always test against default distribution when in a FIPS JVM (#51273)
c5a032b 
(cherry picked from commit e34d7fd)
mark-vieira added a commit that referenced this pull request Jan 22, 2020
@mark-vieira
Revert "Always test against default distribution when in a FIPS JVM (#…
c08c282 
…51273)"

This reverts commit 0169498.
This reverts commit c5a032b.
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Jan 22, 2020
@mark-vieira
Always test against default distribution when in a FIPS JVM (elastic#…
8e32847 
…51273)

(cherry picked from commit e34d7fd)
@mark-vieira mark-vieira mentioned this pull request Jan 22, 2020
Merged
mark-vieira added a commit that referenced this pull request Jan 22, 2020
@mark-vieira
Revert "Always test against default distribution when in a FIPS JVM (#…
792a111 
…51273)"

This reverts commit 0169498.
This reverts commit c5a032b.
mark-vieira added a commit that referenced this pull request Jan 23, 2020
@mark-vieira
Always test against default distribution when in a FIPS JVM (#51273) (#…
f86de2a 
…51333)
mark-vieira added a commit that referenced this pull request Jan 23, 2020
@mark-vieira
Always test against default distribution when in a FIPS JVM (#51273) (#…
11fd96d 
…51333)
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkakavas jkakavas jkakavas approved these changes

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distribution tests failing due to unknown setting [xpack.security.ssl.diagnose.trust]
6 participants
@mark-vieira @elasticmachine @rjernst @jkakavas @jakelandis @polyfractal