Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution tests failing due to unknown setting [xpack.security.ssl.diagnose.trust] #50364

Closed
davidkyle opened this issue Dec 19, 2019 · 5 comments · Fixed by #51273
Closed
Assignees
Labels
:Security/Security Security issues without another label >test-failure Triaged test failures from CI v7.7.0

Comments

@davidkyle
Copy link
Member

process was found dead while waiting for ports files, node{:distribution:archives:integ-test-zip:integTest-0}

Caused by:


ERROR][o.e.b.ElasticsearchUncaughtExceptionHandler] [integTest-0] uncaught exception in thread [main] |  
-- | --
  | »  org.elasticsearch.bootstrap.StartupException: java.lang.IllegalArgumentException: unknown setting [xpack.security.ssl.diagnose.trust] please check that any required plugins are installed, or check the breaking changes documentation for removed settings |  
  | »  	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:174) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:161) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:125) ~[elasticsearch-cli-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.cli.Command.main(Command.java:90) ~[elasticsearch-cli-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:126) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:92) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  Caused by: java.lang.IllegalArgumentException: unknown setting [xpack.security.ssl.diagnose.trust] please check that any required plugins are installed, or check the breaking changes documentation for removed settings |  
  | »  	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:530) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:475) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:446) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:417) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.common.settings.SettingsModule.<init>(SettingsModule.java:149) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.node.Node.<init>(Node.java:352) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.node.Node.<init>(Node.java:253) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:221) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:221) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:349) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:170) ~[elasticsearch-7.6.0-SNAPSHOT.jar:7.6.0-SNAPSHOT] |  
  | »  	... 6 more

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+matrix-java-periodic/ES_BUILD_JAVA=openjdk13,ES_RUNTIME_JAVA=java8fips,nodes=general-purpose/397/console
https://gradle-enterprise.elastic.co/s/rghajdqd44lle

Related to #49900?

@davidkyle davidkyle added >test-failure Triaged test failures from CI :Security/Security Security issues without another label v7.6.0 labels Dec 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Security)

@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
@jkakavas
Copy link
Member

Related to #49900?

Yes..

 cluster.setting 'xpack.security.ssl.diagnose.trust', 'false'

is applied to all clusters and this fails on oss.

@jkakavas
Copy link
Member

I think that @mark-vieira might have alluded to this in that comment with

Is this safe to do all the time, even when not running in FIPS mode?

but this wasn't obvious in that moment.

There are two things here:

  1. We are running OSS distribution in a FIPS 140 JVM and we shouldn't as this is not supported. Is this easy to exclude @mark-vieira
  2. If the above is not actionable, could we conditionally apply the setting based on distribution type in BuildPlugin ? From the looks of it we can't.

@jkakavas jkakavas self-assigned this Jan 21, 2020
@mark-vieira
Copy link
Contributor

We are running OSS distribution in a FIPS 140 JVM and we shouldn't as this is not supported. Is this easy to exclude @mark-vieira

Sounds like we should just force the use of the default distro when running FIPS tests. Does this sound reasonable?

@jkakavas
Copy link
Member

. Does this sound reasonable?

Yes @mark-vieira 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/Security Security issues without another label >test-failure Triaged test failures from CI v7.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants