Assemble takes into account build.docker=false property #46688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
>enhancement
:Delivery/Build
|
Pinging @elastic/es-core-infra |
probakowski
force-pushed
the
build-docker-assemble
branch
from
174643d to
a89df86
Compare
probakowski
force-pushed
the
build-docker-assemble
branch
from
a89df86 to
aab4e66
Compare
alpar-t
reviewed
Sep 13, 2019
| @@ -175,8 +175,10 @@ for (final boolean oss : [false, true]) { | |||
| addBuildDockerImage(oss) | |||
| } | |||
|
|
|||
| assemble.dependsOn "buildOssDockerImage" | |||
| assemble.dependsOn "buildDockerImage" | |||
| if (System.getProperty("build.docker") != "false") { | |||
There was a problem hiding this comment.
Thanks for looking at this!
We don't want to bring this behavior back, we would want to remove the property form use and documentation.
The reason is that since our distribution now includes a docker image, one can't assemble without it
as assemble is expected to produce all distributions.
|
Closing, as it's not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45034