Build does not take into account system property for missing docker

[costin]

Running the build on an OS (in my case Windows) without docker leads to failure even if the -Dbuild.docker=false property is specified.

> gradlew -Dbuild.docker=false --parallel assemble
...
=======================================
Elasticsearch Build Hamster says Hello!
  Gradle Version        : 5.5.1
  OS Info               : Windows 10 10.0 (amd64)
  JDK Version           : 12 (Oracle Corporation 12.0.2 [Java HotSpot(TM) 64-Bit Server VM 12.0.2+10])
  JAVA_HOME             : E:\jvm\jdk12
  Random Testing Seed   : 23E86B20BFD71C05
=======================================
...
* What went wrong:
Docker (checked [/usr/bin/docker,/usr/local/bin/docker]) is required to run the following tasks:
  :distribution:docker:buildDockerImage
  :distribution:docker:buildOssDockerImage
you can address this by attending to the reported issue, removing the offending tasks from being executed, or by passing -Dbuild.docker=false

The only work-around I found is to exclude the tasks manually:

 -x  :distribution:docker:buildDockerImage -x :distribution:docker:buildOssDockerImage

The issue seems similar to : #43417

[elasticmachine]

Pinging @elastic/es-core-infra

[alpar-t]

This is an oversight in that we made docker mandatory for building artifacts and optional for running tests only, so if you run assemble it will fail that it's required but running check will skip the docker based tests and thus will also avoid building the distribution so it will run to completion.

The recommendation is to build only a specific distribution of interest.

[fayak]

The recommendation is to build only a specific distribution of interest.

What is the best approach to do so ?

[alpar-t]

@fayak for example:

./gradlew -p  distribution/archives/no-jdk-linux-tar assemble

[fayak]

Thanks ! Is there a list of (or a documentation somewhere) of all possible build options/attributes ? I've found few things around, but nothing really clear unfortunately :/

[williamrandolph]

@fayak I have found ./gradlew tasks and ./gradlew tasks --all to be helpful in finding the names of Gradle tasks. The second one has a lot of output, so you may want to grep for "distribution" or "assemble" to find just the possible distributions you can build.

[fayak]

Thanks !
I don't know how helpful it can be, but here's the Dockerfile and entrypoint.sh I use to build a custom version of elasticsearch:
Dockerfile:

FROM openjdk:12-jdk-alpine

RUN apk update && apk add git tree docker py-pip python-dev libffi-dev openssl-dev gcc libc-dev make && rm -rf /var/cache/apk/*

RUN pip install docker-compose

COPY resources/<modified files> /srv
COPY resources/entrypoint.sh /srv

CMD /srv/entrypoint.sh

#!/bin/sh

if [ -z ${ES_VERSION+x} ]; then
    ES_VERSION="v7.3.0"
    echo "Variable ES_VERSION is unset. Setting is to ${ES_VERSION}"
else
    echo "Version to compile: ${ES_VERSION}"
fi

cd /srv || exit 1

git clone https://github.com/elastic/elasticsearch || exit 1
cd elasticsearch || exit 1
git checkout $ES_VERSION

for <custom resources>
find <path> -name <custom resource> -exec cp /srv/<custom> {} \;
done

./gradlew :distribution:docker:assemble --parallel || exit 1

[mark-vieira]

This issue is no longer applicable after the Docker support logic refactor. This property has been removed, and we no longer display it in the error message. Attempting to run the Docker build tasks will continue to fail if Docker is not available on the system. The recommended approach, as mentioned above, is to run the task specific to the distribution you require. This also has the benefit of being much faster than running ./gradlew assemble which builds all flavors of all distributions which is almost never what a user actually desires.