Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformats cat segments API #45397

Merged
merged 2 commits into from
Aug 12, 2019
Merged

[DOCS] Reformats cat segments API #45397

merged 2 commits into from
Aug 12, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Aug 9, 2019

@jrodewig jrodewig added >docs General docs changes :Data Management/CAT APIs Text APIs behind /_cat v8.0.0 v7.4.0 v7.3.1 labels Aug 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jrodewig jrodewig force-pushed the cat-segments-reformat branch from b80515b to ecc69ca Compare August 9, 2019 17:56
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment.

`docs.deleted`::
(Default) Number of deleted documents in the segment, such as `0`. This number
is based on Lucene documents. {es} reclaims the disk space of Lucene documents a
segment is merged.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this last sentence is missing a "when"? Not sure I'd repeat "Lucene" -- I think the more important point is that the disk space from deleted documents is reclaimed when segments are merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @debadair. Fixed with 96a1d9c.

@jrodewig jrodewig requested a review from debadair August 9, 2019 18:41
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit c70e16d into master Aug 12, 2019
@jrodewig jrodewig deleted the cat-segments-reformat branch August 12, 2019 12:25
jrodewig added a commit that referenced this pull request Aug 12, 2019
jrodewig added a commit that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants