-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Reformats cat segments API #45397
Conversation
Pinging @elastic/es-docs |
Pinging @elastic/es-core-features |
b80515b
to
ecc69ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment.
docs/reference/cat/segments.asciidoc
Outdated
`docs.deleted`:: | ||
(Default) Number of deleted documents in the segment, such as `0`. This number | ||
is based on Lucene documents. {es} reclaims the disk space of Lucene documents a | ||
segment is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this last sentence is missing a "when"? Not sure I'd repeat "Lucene" -- I think the more important point is that the disk space from deleted documents is reclaimed when segments are merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the cat segments API to align with the new API reference template.
Relates to elastic/docs#937 and #45196
Preview
http://elasticsearch_45397.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/cat-segments.html