[Geo] Refactor GeoShapeQueryBuilder to derive from AbstractGeometryQueryBuilder

[nknize]

Refactors GeoShapeQueryBuilder to derive from a new AbstractShapeQueryBuilder that provides common parsing and build logic for spatial shapes. This will allow development of custom shape queries by extending AbstractShapeQueryBuilder, preventing the duplication of common shape query logic.

note: #44715 further deprecates ShapeBuilder to make the QueryBuilder more spatial agnostic and will be included upon merge.

Relates to #40908

[nknize]

@elasticmachine run elasticsearch-ci/1
@elasticmachine run elasticsearch-ci/2

[imotov]

It looks good in general but let's get #44715 in first and merge it into this one. I think it should dramatically simplify GeoShapeQueryBuilder ideally leaving only legacy-specific logic there. I think the goal should be to move as much non-legacy logic fromGeoShapeQueryBuilder into GeometryIndexer as possible, otherwise it will force us to add the corresponding XYShape-specific logic to XYShapeQueryBuilder which is part of HL Rest client.

[nknize]

I agree on getting #44715 in first (I'm already merging it with this dev branch as part of the PR review).

We're also going to need to be careful about naming because the field type that exposes Lucene's LatLonShape is called geo_shape and the field type that exposes Lucene's XYShape is called geometry so we risk getting confused by terminology where lat,lon geometries are called geo and x,y geometries are called geometry. GeometryIndexer is a good example, I think we'll need to carefully document that class to make it clear that it's intended for lat,lon geometries (or rename it to something like GeodeticIndexer differentiating between Geodetic lat, lon and Geocentric XYZ, or tangential plane XY).

[imotov]

I merged #44715 into master. Thanks for the review!

[nknize]

np; and I just merged those changes from master w/ this PR. Let's see how CI responds and I think this will be good to go. Per our team discuss this morning I renamed AbstractShapeQueryBuilder to AbstractGeometryQueryBuilder to try and keep the naming conventions clearer. Now we have GeoShapeQueryBuilder (and soon ShapeQueryBuilder) that will derive from this new AbstractGeometryQueryBuilder. I also like how AbstractGeometryQueryBuilder now has no dependencies on jts or spatial4j, only GeoShapeQueryBuilder does for legacy purposes. It will make it easier to remove those dependencies once we get there.

[imotov]

LGTM. Thanks!

[imotov]

I think in the next iteration I am going to move this into AbstractGeometryIndexer and make it obtainable from QueryShardContext.

[nknize]

Do you want to also @deprecate it in 8.0 (master) in advance of its removal in 9.0?

[nknize]

Oh... oops.. Sorry, you were referring to getVectorQuery. I think that's a great idea.