Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo: deprecate ShapeBuilder in QueryBuilders #44715

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Jul 22, 2019

Removes unnecessary now timeline decompositions from shape builders
and deprecates ShapeBuilders in QueryBuilder in favor of libs/geo
shapes.

Relates to #40908

Removes unnecessary now timeline decompositions from shape builders
and deprecates ShapeBuilders in QueryBuilder in favor of libs/geo
shapes.

Relates to elastic#40908
@imotov imotov added :Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring v8.0.0 v7.4.0 labels Jul 22, 2019
@imotov imotov requested review from talevy and nknize July 22, 2019 19:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

Copy link
Contributor

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged this offline with #44780 and it LGTM

@imotov imotov removed the request for review from talevy July 24, 2019 18:05
@imotov imotov merged commit 34675ca into elastic:master Jul 24, 2019
imotov added a commit that referenced this pull request Jul 24, 2019
Removes unnecessary now timeline decompositions from shape builders
and deprecates ShapeBuilders in QueryBuilder in favor of libs/geo
shapes.

Relates to #40908
imotov added a commit to imotov/elasticsearch that referenced this pull request Jul 31, 2019
Add Geometry-based method for creation of query builders in
QueryBuilder

Relates to elastic#44715
imotov added a commit that referenced this pull request Aug 2, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add Geometry-based method for creation of query builders in
QueryBuilder

Relates to #44715
imotov added a commit that referenced this pull request Aug 5, 2019
Add Geometry-based method for creation of query builders in
QueryBuilder

Relates to #44715
@imotov imotov deleted the issue-40908-replace-shape-builder-in-query-builders branch May 1, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants