Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ILM package to ilm #44725

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Rename ILM package to ilm #44725

merged 1 commit into from
Jul 23, 2019

Conversation

jasontedor
Copy link
Member

This commit renames the ILM package from indexlifecycle to ilm. We have all come to know index lifecycle management as ILM, the APIs and settings use ilm, and it would be nice of the package did too. This commit makes that change.

Relates #44608

This commit renames the ILM package from indexlifecycle to ilm. We have
all come to know index lifecycle management as ILM, the APIs and
settings use ilm, and it would be nice of the package did too. This
commit makes that change.
@jasontedor jasontedor added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.4.0 labels Jul 22, 2019
@jasontedor jasontedor requested review from dakrone and gwbrown July 22, 2019 22:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jasontedor
Copy link
Member Author

jasontedor commented Jul 22, 2019

For further background, see my comment on the PR renaming the SLM packages. This change here could be seen as breaking, since it would change the name of loggers. Since we don't offer any backwards compatibility guarantees about loggers and logging, I don't think we should consider it as breaking, but I want to make sure that we have a proper discussion about this.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's okay since as you said, we don't have backwards compatibility guarantees for logging names

@jasontedor jasontedor merged commit 69ada4d into elastic:master Jul 23, 2019
jasontedor added a commit that referenced this pull request Jul 23, 2019
This commit renames the ILM package from indexlifecycle to ilm. We have
all come to know index lifecycle management as ILM, the APIs and
settings use ilm, and it would be nice of the package did too. This
commit makes that change.
@jasontedor jasontedor deleted the ilm-package branch July 23, 2019 08:15
@jasontedor
Copy link
Member Author

@dakrone @gwbrown I do not intend to backport this change to any branches that are in maintenance mode: 6.8, 7.2, and 7.3. This is because I expect backports to not be numerous (we aren't adding new features), and rename detection should be fine in nearly all cases. For 6.8 which will be longer running than 7.2 and 7.3, I could see an argument to backport but am for now going to hold off. Let me know if you think otherwise, and of course, we can revisit this in the future too should backports prove more frequent or comprehensive than we currently think they will be.

@dakrone
Copy link
Member

dakrone commented Jul 23, 2019

I agree that this should only be backported to 7.4, I don't think not backporting it will cause any problems.

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 26, 2019
As a followup to elastic#44725 and elastic#44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
dakrone added a commit that referenced this pull request Jul 29, 2019
As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 29, 2019
)

As a followup to elastic#44725 and elastic#44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 29, 2019
Related to elastic#44917 and elastic#44725, this commit renames the HLRC components
for indexlifecycle to ilm.
dakrone added a commit that referenced this pull request Jul 29, 2019
* Rename indexlifecycle to ilm and snapshotlifecycle to slm (#44917)

As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.

* Fix one more import
dakrone added a commit that referenced this pull request Jul 30, 2019
Related to #44917 and #44725, this commit renames the HLRC components
for indexlifecycle to ilm.
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
Related to #44917 and #44725, this commit renames the HLRC components
for indexlifecycle to ilm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants