-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ILM package to ilm #44725
Rename ILM package to ilm #44725
Conversation
This commit renames the ILM package from indexlifecycle to ilm. We have all come to know index lifecycle management as ILM, the APIs and settings use ilm, and it would be nice of the package did too. This commit makes that change.
Pinging @elastic/es-core-features |
For further background, see my comment on the PR renaming the SLM packages. This change here could be seen as breaking, since it would change the name of loggers. Since we don't offer any backwards compatibility guarantees about loggers and logging, I don't think we should consider it as breaking, but I want to make sure that we have a proper discussion about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think it's okay since as you said, we don't have backwards compatibility guarantees for logging names
This commit renames the ILM package from indexlifecycle to ilm. We have all come to know index lifecycle management as ILM, the APIs and settings use ilm, and it would be nice of the package did too. This commit makes that change.
@dakrone @gwbrown I do not intend to backport this change to any branches that are in maintenance mode: 6.8, 7.2, and 7.3. This is because I expect backports to not be numerous (we aren't adding new features), and rename detection should be fine in nearly all cases. For 6.8 which will be longer running than 7.2 and 7.3, I could see an argument to backport but am for now going to hold off. Let me know if you think otherwise, and of course, we can revisit this in the future too should backports prove more frequent or comprehensive than we currently think they will be. |
I agree that this should only be backported to 7.4, I don't think not backporting it will cause any problems. |
As a followup to elastic#44725 and elastic#44608, which renamed the packages within the x-pack project, this renames the packages within the core x-pack project. It also renames 'snapshotlifecycle' within the HLRC to slm.
) As a followup to elastic#44725 and elastic#44608, which renamed the packages within the x-pack project, this renames the packages within the core x-pack project. It also renames 'snapshotlifecycle' within the HLRC to slm.
Related to elastic#44917 and elastic#44725, this commit renames the HLRC components for indexlifecycle to ilm.
This commit renames the ILM package from indexlifecycle to ilm. We have all come to know index lifecycle management as ILM, the APIs and settings use ilm, and it would be nice of the package did too. This commit makes that change.
Relates #44608