Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SLM package to slm #44608

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Rename SLM package to slm #44608

merged 1 commit into from
Jul 22, 2019

Conversation

jasontedor
Copy link
Member

This commit renames the SLM package from snapshotlifecycle to slm. We have all come to know index lifecycle management as ILM, the APIs and settings use ilm, and it would be nice of the package did too. For SLM, let's use slm for all of these including the package name from the beginning.

This commit renames the SLM package from snapshotlifecycle to slm. We
have all come to know index lifecycle management as ILM, the APIs and
settings use ilm, and it would be nice of the package did too. For SLM,
let's use slm for all of these including the package name from the
beginning.
@jasontedor jasontedor added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.4.0 labels Jul 19, 2019
@jasontedor jasontedor requested a review from dakrone July 19, 2019 06:35
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jasontedor jasontedor requested a review from gwbrown July 20, 2019 22:26
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, while we're at it, should we renamed the indexlifecycle packages to ilm?

@jasontedor
Copy link
Member Author

LGTM, while we're at it, should we renamed the indexlifecycle packages to ilm?

Yes, I planned to do it in a follow-up after this one, to see if this one would be accepted first and noting that the ILM one will be a tiny bit controversial. This is because it could be considered a breaking change (from changing logging names). I don't think we should consider it a breaking change, because we don't make any guarantees about logging whatsoever, but I want to make sure that we have a proper discussion about it.

@jasontedor jasontedor merged commit 343bb08 into elastic:master Jul 22, 2019
jasontedor added a commit that referenced this pull request Jul 22, 2019
This commit renames the SLM package from snapshotlifecycle to slm. We
have all come to know index lifecycle management as ILM, the APIs and
settings use ilm, and it would be nice of the package did too. For SLM,
let's use slm for all of these including the package name from the
beginning.
@jasontedor jasontedor deleted the slm-package branch July 22, 2019 22:44
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 26, 2019
As a followup to elastic#44725 and elastic#44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
dakrone added a commit that referenced this pull request Jul 29, 2019
As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 29, 2019
)

As a followup to elastic#44725 and elastic#44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
dakrone added a commit that referenced this pull request Jul 29, 2019
* Rename indexlifecycle to ilm and snapshotlifecycle to slm (#44917)

As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.

* Fix one more import
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants