Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric on watcher stats is a list not an enum (#39114) #39646

Merged

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Mar 4, 2019

enum is a single option from a known list of options
list is an array of unknown values
flags are multiple options from a list of known options.

We don't support the flags type but a list with options acts as one. This is already the case for other API's taking metric such as node.stats.json.

watcher.stats behaves the same as other API's as metrics and as such accepts the following GET _xpack/watcher/stats/queued_watches,current_watches

(cherry picked from commit 4c00a02)

`enum` is a single option from a known list of `options`
`list` is an array of unknown values
`flags` are multiple options from a list of known `options`.

We don't support the `flags` type but a `list` with `options` acts as one. This is already the case for other API's taking metric such as `node.stats.json`. 

watcher.stats behaves the same as other API's as `metrics` and as such accepts the following `GET _xpack/watcher/stats/queued_watches,current_watches`

(cherry picked from commit 4c00a02)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@Mpdreamz Mpdreamz merged commit 7822787 into elastic:7.0 Mar 4, 2019
@Mpdreamz Mpdreamz deleted the fix/rest-spec-watcher-stats-metric-7.0 branch March 4, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants