metric on watcher stats is a list not an enum #39114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`enum` is a single option from a known list of `options` `list` is an array of unknown values `flags` are multiple options from a list of known `options`. We don't support the `flags` type but a `list` with `options` acts as one. This is already the case for other API's taking metric such as `node.stats.json`. watcher.stats behaves the same as other API's as `metrics` and as such accepts the following `GET _xpack/watcher/stats/queued_watches,current_watches`
Mpdreamz
added
>bug
:Core/Infra/REST API
|
Pinging @elastic/es-core-infra |
|
Pinging @elastic/es-core-features |
jakelandis
approved these changes
Feb 19, 2019
|
I will submit an additional PR to update the rest-spec README Also will need some love if #39063 makes it in. Thanks for the review @jakelandis! |
Mpdreamz
added a commit
to Mpdreamz/elasticsearch
that referenced
this pull request
Mar 4, 2019
`enum` is a single option from a known list of `options` `list` is an array of unknown values `flags` are multiple options from a list of known `options`. We don't support the `flags` type but a `list` with `options` acts as one. This is already the case for other API's taking metric such as `node.stats.json`. watcher.stats behaves the same as other API's as `metrics` and as such accepts the following `GET _xpack/watcher/stats/queued_watches,current_watches` (cherry picked from commit 4c00a02)
Mpdreamz
added a commit
to Mpdreamz/elasticsearch
that referenced
this pull request
Mar 4, 2019
`enum` is a single option from a known list of `options` `list` is an array of unknown values `flags` are multiple options from a list of known `options`. We don't support the `flags` type but a `list` with `options` acts as one. This is already the case for other API's taking metric such as `node.stats.json`. watcher.stats behaves the same as other API's as `metrics` and as such accepts the following `GET _xpack/watcher/stats/queued_watches,current_watches` (cherry picked from commit 4c00a02)
Mpdreamz
added a commit
that referenced
this pull request
Mar 4, 2019
`enum` is a single option from a known list of `options` `list` is an array of unknown values `flags` are multiple options from a list of known `options`. We don't support the `flags` type but a `list` with `options` acts as one. This is already the case for other API's taking metric such as `node.stats.json`. watcher.stats behaves the same as other API's as `metrics` and as such accepts the following `GET _xpack/watcher/stats/queued_watches,current_watches` (cherry picked from commit 4c00a02)
Mpdreamz
added a commit
that referenced
this pull request
Mar 4, 2019
`enum` is a single option from a known list of `options` `list` is an array of unknown values `flags` are multiple options from a list of known `options`. We don't support the `flags` type but a `list` with `options` acts as one. This is already the case for other API's taking metric such as `node.stats.json`. watcher.stats behaves the same as other API's as `metrics` and as such accepts the following `GET _xpack/watcher/stats/queued_watches,current_watches` (cherry picked from commit 4c00a02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enumis a single option from a known list ofoptionslistis an array of unknown valuesflagsare multiple options from a list of knownoptions.We don't support the
flagstype but alistwithoptionsacts as one. This is already the case for other API's taking metric such asnode.stats.json.watcher.stats behaves the same as other API's as
metricsand as such accepts the followingGET _xpack/watcher/stats/queued_watches,current_watchescc @elastic/es-clients