-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce retention lease actions #38756
Merged
jasontedor
merged 11 commits into
elastic:master
from
jasontedor:retention-lease-actions
Feb 12, 2019
Merged
Introduce retention lease actions #38756
jasontedor
merged 11 commits into
elastic:master
from
jasontedor:retention-lease-actions
Feb 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces actions for some common retention lease operations that clients need to be able to perform remotely. These actions include add/renew/remove.
jasontedor
added
>enhancement
v7.0.0
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
v6.7.0
v8.0.0
v7.2.0
labels
Feb 12, 2019
jasontedor
requested review from
martijnvg,
bleskes,
ywelsch,
DaveCTurner and
dnhatn
February 12, 2019 00:14
Pinging @elastic/es-distributed |
24 tasks
@elasticmachine run elasticsearch-ci/1 |
@elasticmachine run elasticsearch-ci/2 |
* master: Enable removal of retention leases (elastic#38751) Make the 'get templates' types deprecation message consistent. (elastic#38533) Copy retention leases when trim unsafe commits (elastic#37995) Fix the version check for LegacyGeoShapeFieldMapper (elastic#38547)
dnhatn
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a minor comment.
server/src/main/java/org/elasticsearch/index/seqno/RetentionLeaseActions.java
Outdated
Show resolved
Hide resolved
* master: Add dedicated retention lease exceptions (elastic#38754) add debug logging to SimpleClusterStateIT#testIndicesOptions (elastic#38752)
martijnvg
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jasontedor
added a commit
that referenced
this pull request
Feb 12, 2019
This commit introduces actions for some common retention lease operations that clients need to be able to perform remotely. These actions include add/renew/remove.
jasontedor
added a commit
that referenced
this pull request
Feb 12, 2019
This commit introduces actions for some common retention lease operations that clients need to be able to perform remotely. These actions include add/renew/remove.
jasontedor
added a commit
that referenced
this pull request
Feb 12, 2019
This commit introduces actions for some common retention lease operations that clients need to be able to perform remotely. These actions include add/renew/remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
>enhancement
v6.7.0
v7.0.0-rc1
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces actions for some common retention lease operations that clients need to be able to perform remotely. These actions include add/renew/remove.
Relates #37165